Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 963493002: Revert of Retry to add MockPresentationClient to use in layout tests. (Closed)

Created:
5 years, 10 months ago by whywhat
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Retry to add MockPresentationClient to use in layout tests. (patchset #4 id:60001 of https://codereview.chromium.org/907893002/) Reason for revert: While the LayoutTests only test the logic in the mocks and the plumbing, maintaining the mocks while working on the platform/public interface is a pain and requires landing patches simultaneously in Blink and Chromium repositories. There's no layout test using this anyway yet. I'll add layout tests later when the Blink-Chromium interface is stable and maybe Blink is merged into Chromium. Original issue's description: > Retry to add MockPresentationClient to use in layout tests. > > Now there's a MockPresentationService that's owned by WebTestProxy and > accepts private method calls from the tests. > > MockPresentationClient was moved to WebFrameTestProxy instance since > we want one per each frame. Reset logic is added too to make tests more > independent. > > BUG=412331 > > Committed: https://crrev.com/57b3af2412a81a4c0abf54e0146c0f7bf5530249 > Cr-Commit-Position: refs/heads/master@{#316199} TBR=mkwst@chromium.org,peter@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=412331 Committed: https://crrev.com/49001892c02a5287233acc68edaaf2e0dc981163 Cr-Commit-Position: refs/heads/master@{#318230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -267 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_client.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_client.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_service.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_service.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +0 lines, -13 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
whywhat
Created Revert of Retry to add MockPresentationClient to use in layout tests.
5 years, 10 months ago (2015-02-26 14:18:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963493002/1
5 years, 10 months ago (2015-02-26 14:18:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 14:19:42 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 14:20:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49001892c02a5287233acc68edaaf2e0dc981163
Cr-Commit-Position: refs/heads/master@{#318230}

Powered by Google App Engine
This is Rietveld 408576698