Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 963453003: [Ozone-Dri] Allocate cursor buffers on the correct DRM device (Closed)

Created:
5 years, 10 months ago by dnicoara
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@allocate-cursor-on-correct-device
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Dri] Allocate cursor buffers on the correct DRM device Need to keep track of changing displays and update the cursor buffers when the window moves between DRM devices. BUG=461105 Committed: https://crrev.com/f95b436fae524522a65bdbcd8bd0defaae691290 Cr-Commit-Position: refs/heads/master@{#318252}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -36 lines) Patch
M ui/ozone/platform/dri/dri_window_delegate_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.cc View 1 6 chunks +42 lines, -28 lines 3 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl_unittest.cc View 4 chunks +33 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
PTAL
5 years, 10 months ago (2015-02-26 15:03:29 UTC) #2
alexst (slow to review)
https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc File ui/ozone/platform/dri/dri_window_delegate_impl.cc (right): https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc#newcode130 ui/ozone/platform/dri/dri_window_delegate_impl.cc:130: bool should_allocate_cursor_buffers = controller_ != controller; Why not just ...
5 years, 10 months ago (2015-02-26 15:28:21 UTC) #3
dnicoara
https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc File ui/ozone/platform/dri/dri_window_delegate_impl.cc (right): https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc#newcode130 ui/ozone/platform/dri/dri_window_delegate_impl.cc:130: bool should_allocate_cursor_buffers = controller_ != controller; On 2015/02/26 15:28:21, ...
5 years, 10 months ago (2015-02-26 15:31:30 UTC) #4
alexst (slow to review)
lgtm https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc File ui/ozone/platform/dri/dri_window_delegate_impl.cc (right): https://codereview.chromium.org/963453003/diff/20001/ui/ozone/platform/dri/dri_window_delegate_impl.cc#newcode130 ui/ozone/platform/dri/dri_window_delegate_impl.cc:130: bool should_allocate_cursor_buffers = controller_ != controller; On 2015/02/26 ...
5 years, 10 months ago (2015-02-26 15:35:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963453003/20001
5 years, 10 months ago (2015-02-26 17:24:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 17:34:08 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 17:34:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f95b436fae524522a65bdbcd8bd0defaae691290
Cr-Commit-Position: refs/heads/master@{#318252}

Powered by Google App Engine
This is Rietveld 408576698