Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 963433002: Make landmines delete all generated build artifacts. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make landmines delete all generated build artifacts. BUG=chromium:403263 LOG=n Committed: https://crrev.com/03cef94a4908c2dc1a1c41987bc834923be4eb6e Cr-Commit-Position: refs/heads/master@{#26877}

Patch Set 1 #

Patch Set 2 : Wrong scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/landmines.py View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-26 11:04:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-26 12:35:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963433002/20001
5 years, 10 months ago (2015-02-26 12:38:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 12:39:45 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 12:39:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03cef94a4908c2dc1a1c41987bc834923be4eb6e
Cr-Commit-Position: refs/heads/master@{#26877}

Powered by Google App Engine
This is Rietveld 408576698