Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 963423003: Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON (Closed)

Created:
5 years, 9 months ago by eroman
Modified:
5 years, 9 months ago
Reviewers:
jam, mtklein, mtklein_C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/965113002/) Reason for revert: Revert did not help, restoring original patch Original issue's description: > Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/966593002/) > > Reason for revert: > May have caused FontRenderParamsTest failures on Linux debug bots. > > Original issue's description: > > SK_DEBUG when DCHECK_ALWAYS_ON > > > > BUG= > > > > Committed: https://crrev.com/879405ae813ae4a9bcbd7684d3551420d4980383 > > Cr-Commit-Position: refs/heads/master@{#318557} > > TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/6197d8798bb0282d42b69c535b17bd2cd92c3b38 > Cr-Commit-Position: refs/heads/master@{#318581} TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d3cea3c54f0025f0d3d06fca853f1999b29835b5 Cr-Commit-Position: refs/heads/master@{#318600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Created Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON
5 years, 9 months ago (2015-02-28 05:19:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963423003/1
5 years, 9 months ago (2015-02-28 05:20:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 05:21:12 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 05:21:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3cea3c54f0025f0d3d06fca853f1999b29835b5
Cr-Commit-Position: refs/heads/master@{#318600}

Powered by Google App Engine
This is Rietveld 408576698