Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 963393002: X87: Disallow subclassing Arrays. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Disallow subclassing Arrays. port 290ee378ea44bda379cb3e1864631895c7dea774 (r26931). original commit message: UG= R=weiliang.lin@intel.com Committed: https://crrev.com/8b33fa60691fe3d0d0e2ee6b751b89de6abec626 Cr-Commit-Position: refs/heads/master@{#26932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-02-28 02:46:40 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-02-28 02:55:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963393002/1
5 years, 9 months ago (2015-02-28 02:56:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_linux64_asan_rel on ...
5 years, 9 months ago (2015-02-28 04:56:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963393002/1
5 years, 9 months ago (2015-02-28 06:56:43 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b33fa60691fe3d0d0e2ee6b751b89de6abec626 Cr-Commit-Position: refs/heads/master@{#26932}
5 years, 9 months ago (2015-02-28 08:29:41 UTC) #10
chunyang.dai
5 years, 9 months ago (2015-02-28 08:29:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b33fa60691fe3d0d0e2ee6b751b89de6abec626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698