Issue 963383002: Address NewApi Android lint warnings in src/content.

Issue 963383002: Address NewApi Android lint warnings in src/content. (Closed)

Created:
5 years, 9 months ago by newt (away)

Modified:
5 years, 9 months ago

Reviewers:
David Trainor- moved to gerrit, dmazzoni

CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Address NewApi Android lint warnings in src/content. Annotate several classes with @TargetApi so lint knows that those classes can safely use methods introduced in various versions of Android. BUG=266140 Committed: https://crrev.com/22c3f9458f1f7bc3c50f8f873a5978cac67b42eb Cr-Commit-Position: refs/heads/master@{#318751}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -3 lines)			Patch
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanBrowserAccessibilityManager.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopAccessibilityInjector.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

newt (away)

PTAL dmazzoni: accessibility/* dtrainor: ContentViewCore.java

5 years, 9 months ago (2015-02-28 01:24:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963383002/1

5 years, 9 months ago (2015-03-02 19:07:29 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 21:06:49 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22c3f9458f1f7bc3c50f8f873a5978cac67b42eb
Cr-Commit-Position: refs/heads/master@{#318751}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages