Issue 963303004: Implement shake-to-reload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963303004: Implement shake-to-reload (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Implement shake-to-reload Apps can import this library if they wish to reload on shake. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ba9e5126939a721bd525779710ff1c4365725b06

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -1 line)			Patch
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	sky/examples/touch-demo.sky	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/framework/debug/shake-to-reload.sky	View	1 chunk	+43 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/963303004/diff/1/sky/framework/debug/shake-to-reload.sky File sky/framework/debug/shake-to-reload.sky (right): https://codereview.chromium.org/963303004/diff/1/sky/framework/debug/shake-to-reload.sky#newcode6 sky/framework/debug/shake-to-reload.sky:6: // TODO(abarth): We should factor this out into ...

5 years, 9 months ago (2015-02-27 23:29:53 UTC) #2

abarth-chromium

5 years, 9 months ago (2015-02-27 23:31:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ba9e5126939a721bd525779710ff1c4365725b06 (presubmit successful).

Expand Messages | Collapse Messages