Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 963303003: ui: Make the aura_demo not have solid colors in its layers. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
sadrul, sky, piman
CC:
chromium-reviews, kalyank, sadrul, enne (OOO), weiliangc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Make the aura_demo not have solid colors in its layers. This forces the compositor to use textures and allows us to verify the texture upload path is working, instead of just testing solid color layers work. R=sadrul Committed: https://crrev.com/c9631120eda194fbaf702c84e8beb187ba7c6414 Cr-Commit-Position: refs/heads/master@{#318802}

Patch Set 1 #

Total comments: 2

Patch Set 2 : democolor: comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/aura/demo/demo_main.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
danakj
5 years, 9 months ago (2015-02-27 22:53:43 UTC) #2
piman
lgtm
5 years, 9 months ago (2015-02-27 23:10:43 UTC) #4
piman
Oh, not owner here. Funny.
5 years, 9 months ago (2015-02-27 23:11:06 UTC) #5
danakj
+sky
5 years, 9 months ago (2015-02-28 00:15:37 UTC) #7
sadrul
lgtm
5 years, 9 months ago (2015-02-28 01:57:44 UTC) #8
sky
https://codereview.chromium.org/963303003/diff/1/ui/aura/demo/demo_main.cc File ui/aura/demo/demo_main.cc (right): https://codereview.chromium.org/963303003/diff/1/ui/aura/demo/demo_main.cc#newcode69 ui/aura/demo/demo_main.cc:69: while (!r.IsEmpty()) { This is worth a comment. Also, ...
5 years, 9 months ago (2015-02-28 17:32:16 UTC) #9
danakj
https://codereview.chromium.org/963303003/diff/1/ui/aura/demo/demo_main.cc File ui/aura/demo/demo_main.cc (right): https://codereview.chromium.org/963303003/diff/1/ui/aura/demo/demo_main.cc#newcode69 ui/aura/demo/demo_main.cc:69: while (!r.IsEmpty()) { On 2015/02/28 17:32:16, sky wrote: > ...
5 years, 9 months ago (2015-03-02 20:12:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963303003/20001
5 years, 9 months ago (2015-03-02 23:15:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 23:50:40 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:52:42 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9631120eda194fbaf702c84e8beb187ba7c6414
Cr-Commit-Position: refs/heads/master@{#318802}

Powered by Google App Engine
This is Rietveld 408576698