Issue 963253002: Move FilterEffectRenderer out of RenderLayer into RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963253002: Move FilterEffectRenderer out of RenderLayer into RenderBox. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move FilterEffectRenderer out of RenderLayer into RenderBox. It doesn't do anything RenderLayer specific anymore. This does mean adding another pointer to RenderBox. We might want to do something about that eventually, but for now it seems fine to make forward progress in terms of getting rid of the RenderLayer tree. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9b8502fc92396a703d06a5b1089bf3f73b9ec917

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -48 lines)			Patch
M	sky/engine/core/rendering/FilterEffectRenderer.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/FilterEffectRenderer.cpp	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	3 chunks	+18 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.h	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.cpp	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

5 years, 9 months ago (2015-02-27 21:42:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b8502fc92396a703d06a5b1089bf3f73b9ec917 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages