Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 963233003: base: Remove DiscardableMemoryMach. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove DiscardableMemoryMach. Remove unused DiscardableMemory implementation. BUG=442945, 422953 Committed: https://crrev.com/073fe47b5cb9bff983ba0e62c068f438fab819df Cr-Commit-Position: refs/heads/master@{#320171}

Patch Set 1 #

Patch Set 2 : fix native_discardable_memory% #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -227 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M base/base.gypi View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M base/memory/discardable_memory.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_memory.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_memory_android.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_memory_mac.cc View 1 2 3 3 chunks +1 line, -12 lines 0 comments Download
D base/memory/discardable_memory_mach.h View 1 chunk +0 lines, -46 lines 0 comments Download
D base/memory/discardable_memory_mach.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M base/memory/discardable_memory_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M build/common.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
reveman
5 years, 9 months ago (2015-02-27 23:02:37 UTC) #2
Avi (use Gerrit)
lgtm OK.
5 years, 9 months ago (2015-02-27 23:15:35 UTC) #3
reveman
+danakj for base/
5 years, 9 months ago (2015-03-11 14:40:58 UTC) #5
danakj
LGTM
5 years, 9 months ago (2015-03-11 17:20:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963233003/60001
5 years, 9 months ago (2015-03-11 17:37:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48936)
5 years, 9 months ago (2015-03-11 18:06:13 UTC) #11
reveman
+jochen,thakis for build/common.gypi
5 years, 9 months ago (2015-03-11 18:16:52 UTC) #13
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-11 18:27:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963233003/60001
5 years, 9 months ago (2015-03-11 19:38:00 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-11 22:45:51 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 22:47:02 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/073fe47b5cb9bff983ba0e62c068f438fab819df
Cr-Commit-Position: refs/heads/master@{#320171}

Powered by Google App Engine
This is Rietveld 408576698