Implement i18n::addressinput::Downloader for requestAutocomplete() (and

Implement i18n::addressinput::Downloader for requestAutocomplete() (and
eventually all of Autofill).

R=estade@chromium.org,rouslan@chromium.org
BUG=317838

[please use gerrit instead, 2013-12-02 17:03:54]

Good stuff!

https://codereview.chromium.org/96323002/diff/80001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.h (right):

https://codereview.chromium.org/96323002/diff/80001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h:607:
ValidationDownloader validation_downloader_;
This object will be owned by libaddressinput, so there's no need to instantiate
it here. The interface will be:

  AddressValidation(Downloader*, Storage*)

You would instantiate it with:

  AddressValidation validation(new ValidationDownloader(context),
                               new ValidationStorage(context)).

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
File components/autofill/core/browser/validation_downloader.cc (right):

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
components/autofill/core/browser/validation_downloader.cc:43: // |source| is
owned by |fetchers_| and will be deleted later.
You could also do:

  fetchers_.erase(source);

[please use gerrit instead, 2013-12-02 17:33:26]

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
File components/autofill/core/browser/validation_downloader.cc (right):

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
components/autofill/core/browser/validation_downloader.cc:16:
ValidationDownloader::~ValidationDownloader() {}
Please invoke the remaining |callbacks_| with parameters (false, url,
std::string()) before deleting them. This will ensure that libaddressinput
cleans up its resources.

[Evan Stade, 2013-12-02 21:50:03]

https://chromiumcodereview.appspot.com/96323002/diff/80001/components/autofil...
File components/autofill/core/browser/validation_downloader.cc (right):

https://chromiumcodereview.appspot.com/96323002/diff/80001/components/autofil...
components/autofill/core/browser/validation_downloader.cc:21: net::URLFetcher*
fetcher(
The entirety of this function should be:

  new I18nDownloadRequest(url, callback);

And all the actual functionality is handled in the I18nDownloadRequest class.

[Evan Stade, 2013-12-04 20:23:38]

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
File components/autofill/core/browser/validation_downloader.cc (right):

https://codereview.chromium.org/96323002/diff/80001/components/autofill/core/...
components/autofill/core/browser/validation_downloader.cc:24:
fetcher->SetRequestContext(getter_);
Also you will want:

  fetcher->SetLoadFlags(
      net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);

[Evan Stade, 2014-01-07 22:29:46]

picking this one up.