Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 963223002: ui: Pass correct image texture target and one-copy settings to cc. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
reveman, piman
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, enne (OOO), jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick, weiliangc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Pass correct image texture target and one-copy settings to cc. The ui browser compositor should use onecopy for implside painting, as we have enabled that for all platforms that use ui::Compositor. The image texture target should also match the one used in the renderer compositor. So have the ui::Compositor query it from the ContextFactory and move the code that makes the decision out from RenderProcessHostImpl to a shared location. R=piman@chromium.org, reveman BUG=314185 Committed: https://crrev.com/e6eb185c92a58e034bbe31e89bf3ac7205099527 Cr-Commit-Position: refs/heads/master@{#318551}

Patch Set 1 : usetexturetarget: rebase #

Patch Set 2 : usetexturetarget: RenderThreadImpl-tests #

Patch Set 3 : usetexturetarget: . #

Patch Set 4 : usetexturetarget: exportswitch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -43 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -27 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +5 lines, -13 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
danakj
5 years, 9 months ago (2015-02-27 20:13:38 UTC) #1
reveman
lgtm
5 years, 9 months ago (2015-02-27 20:20:30 UTC) #4
piman
LGTM after compile failure fixed.
5 years, 9 months ago (2015-02-27 21:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963223002/80001
5 years, 9 months ago (2015-02-27 22:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963223002/120001
5 years, 9 months ago (2015-02-27 22:52:01 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:120001)
5 years, 9 months ago (2015-02-27 23:52:20 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 23:53:02 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e6eb185c92a58e034bbe31e89bf3ac7205099527
Cr-Commit-Position: refs/heads/master@{#318551}

Powered by Google App Engine
This is Rietveld 408576698