Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 963193005: MIPS: ARM: Load undefined receiver sentinel without constant pool. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: ARM: Load undefined receiver sentinel without constant pool. Port a820568b1ffbf76c3f80b9e00fc0b988b073dfaf Each call to emit_32 uses 5 constant pool slots: * the "emit_32" string * undefined (the receiver) * the argument (heap number) * the load IC * the call IC This change cuts that down 20% to 4, by loading the undefined from the heap roots. BUG= Committed: https://crrev.com/c4b9d144e0db2df0165dd4e875a1cc0e5b63bcf5 Cr-Commit-Position: refs/heads/master@{#26995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-04 13:48:13 UTC) #2
dusmil.imgtec
lgtm.
5 years, 9 months ago (2015-03-04 14:35:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963193005/1
5 years, 9 months ago (2015-03-04 16:26:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 16:55:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 16:55:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4b9d144e0db2df0165dd4e875a1cc0e5b63bcf5
Cr-Commit-Position: refs/heads/master@{#26995}

Powered by Google App Engine
This is Rietveld 408576698