fpdfsdk/src/javascript/resource.cpp - Issue 963193003: Return error information from pdfium to JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/resource.cpp

Issue 963193003: Return error information from pdfium to JS. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix scope of c_str() Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/resource.cpp

diff --git a/fpdfsdk/src/javascript/resource.cpp b/fpdfsdk/src/javascript/resource.cpp

index 1c453dcda778325de2a5b225f38a92abb8f60d4c..6d67d8ff01b185fa8585d60ef64cfb914428d3c8 100644

--- a/fpdfsdk/src/javascript/resource.cpp

+++ b/fpdfsdk/src/javascript/resource.cpp

@@ -39,8 +39,10 @@ CFX_WideString JSGetStringFromID(CJS_Context* pContext, FX_UINT id)

return L"The second parameter can't be converted to a Date.";

case IDS_STRING_JSPRINT2:

return L"The second parameter is an invalid Date!";

- case IDS_JSPARAM_INCORRECT:

+ case IDS_STRING_JSNOGLOBAL:

return L"Global value not found.";

+ case IDS_STRING_JSREADONLY:

+ return L"Cannot assign to readonly property.";

default:

return L"";

}