Return error information from pdfium to JS.

fpdfsdk/src/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
 #include "../../include/javascript/JS_Value.h"
 #include "../../include/javascript/Document.h"
 #include "../../include/javascript/JS_EventHandler.h"
 #include "../../include/javascript/JS_Context.h"
 #include "../../include/javascript/JS_Runtime.h"
 #include "../../include/javascript/app.h"
 #include "../../include/javascript/Field.h"
 #include "../../include/javascript/Icon.h"
 #include "../../include/javascript/Field.h"

[Lei Zhang, 2015/02/28 02:50:49]

care to remove this duplicate #include while we are here?

[Tom Sepez, 2015/03/02 19:03:44]

You betcha.  I'm going to hold off on sorting these til a follow-up; doing so
usually kicks out more IWYU.

+#include "../../include/javascript/resource.h"
 
 #include "../../../third_party/base/numerics/safe_math.h"
 
 static v8::Isolate* GetIsolate(IFXJS_Context* cc)
 {
         CJS_Context* pContext = (CJS_Context *)cc;
         ASSERT(pContext != NULL);
 
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
@@ skipping 155 matching lines @@
                 }
         }
 
         m_DelayData.RemoveAll();
         m_DelayAnnotData.RemoveAll();
 }
 
 //the total number of fileds in document.
 FX_BOOL Document::numFields(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (!vp.IsGetting()) return FALSE;
-
-        ASSERT(m_pDocument != NULL);
-
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
+                return FALSE;
+        }
         CPDFSDK_InterForm *pInterForm = m_pDocument->GetInterForm();
-        ASSERT(pInterForm != NULL);
-
         CPDF_InterForm *pPDFForm = pInterForm->GetInterForm();
-        ASSERT(pPDFForm != NULL);
-
         vp << (int)pPDFForm->CountFields();
-
         return TRUE;
 }
 
 FX_BOOL Document::dirty(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         if (vp.IsGetting())
         {
                 if (m_pDocument->GetChangeMark())
@@ skipping 654 matching lines @@
         CFX_WideString cwTitle                  = pDictionary->GetUnicodeText("Title");
         CFX_WideString cwSubject                = pDictionary->GetUnicodeText("Subject");
         CFX_WideString cwKeywords               = pDictionary->GetUnicodeText("Keywords");
         CFX_WideString cwCreator                = pDictionary->GetUnicodeText("Creator");
         CFX_WideString cwProducer               = pDictionary->GetUnicodeText("Producer");
         CFX_WideString cwCreationDate   = pDictionary->GetUnicodeText("CreationDate");
         CFX_WideString cwModDate                = pDictionary->GetUnicodeText("ModDate");
         CFX_WideString cwTrapped                = pDictionary->GetUnicodeText("Trapped");
 
         v8::Isolate* isolate = GetIsolate(cc);
-        if (!vp.IsSetting())
+        if (vp.IsGetting())
         {
                 CJS_Context* pContext = (CJS_Context *)cc;
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
 
                 JSFXObject  pObj = JS_NewFxDynamicObj(*pRuntime, pContext, -1);
 
                 JS_PutObjectString(isolate,pObj, L"Author", cwAuthor);
                 JS_PutObjectString(isolate,pObj, L"Title", cwTitle);
                 JS_PutObjectString(isolate,pObj, L"Subject", cwSubject);
                 JS_PutObjectString(isolate,pObj, L"Keywords", cwKeywords);
@@ skipping 236 matching lines @@
                 CFX_WideString cstitle;
                 vp >> cstitle;
                 pDictionary->SetAtString("Title", PDF_EncodeText(cstitle));
                 m_pDocument->SetChangeMark();
                 return TRUE;
         }
 }
 
 FX_BOOL Document::numPages(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (vp.IsGetting())
-        {
-                ASSERT(m_pDocument != NULL);
-                vp << m_pDocument->GetPageCount();
-                return TRUE;
-        }
-        else
-        {
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
                 return FALSE;
         }
+    vp << m_pDocument->GetPageCount();
+    return TRUE;
 }
 
 FX_BOOL Document::external(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
         //In Chrome case,should always return true.
         vp << TRUE;
         return TRUE;
 }
 
 FX_BOOL Document::filesize(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (!vp.IsGetting())return FALSE;
-
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
+                return FALSE;
+        }
         vp << 0;
         return TRUE;
 }
 
 FX_BOOL Document::mouseX(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::mouseY(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
@@ skipping 35 matching lines @@
                 vp >> bCalculate;
 
                 pInterForm->EnableCalculate(bCalculate);
         }
 
         return TRUE;
 }
 
 FX_BOOL Document::documentFileName(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (!vp.IsGetting())
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
                 return FALSE;
-
+        }
         CFX_WideString wsFilePath = m_pDocument->GetPath();
-
         FX_INT32 i = wsFilePath.GetLength() - 1;
         for ( ; i >= 0; i-- )
         {
                 if ( wsFilePath.GetAt( i ) == L'\\' || wsFilePath.GetAt( i ) == L'/' )
                         break;
         }
         if ( i >= 0 && i < wsFilePath.GetLength() - 1 )
         {
                 vp << ( wsFilePath.GetBuffer( wsFilePath.GetLength() ) + i + 1 );
         }else{
@@ skipping 44 matching lines @@
 
         cbFrom.ReleaseBuffer();
         CFX_WideString cbRet = CFX_WideString(pResult);
         free(pResult);
         pResult = NULL;
         return cbRet;
 }
 
 FX_BOOL Document::path(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (!vp.IsGetting()) return FALSE;
-
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
+                return FALSE;
+        }
         vp << app::SysPathToPDFPath(m_pDocument->GetPath());
-
         return TRUE;
 }
 
 FX_BOOL Document::pageWindowRect(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Document::layout(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
@@ skipping 185 matching lines @@
         IconElement* pNewIcon = new IconElement();
         pNewIcon->IconName = swIconName;
         pNewIcon->NextIcon = NULL;
         pNewIcon->IconStream = pIcon;
         m_pIconTree->InsertIconElement(pNewIcon);
         return TRUE;
 }
 
 FX_BOOL Document::icons(IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError)
 {
-        if (vp.IsSetting())
+        if (vp.IsSetting()) {
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
                 return FALSE;
+        }
 
         if (!m_pIconTree)
         {
                 vp.SetNull();
                 return TRUE;
         }
 
         CJS_Array Icons(m_isolate);
         IconElement* pIconElement = NULL;
         int iIconTreeLength = m_pIconTree->GetLength();
@@ skipping 106 matching lines @@
 
         int nPageNo = params.GetSize() > 0 ? (int)params[0] : 0;
         int nWordNo = params.GetSize() > 1 ? (int)params[1] : 0;
         bool bStrip = params.GetSize() > 2 ? (bool)params[2] : true;
 
         CPDF_Document* pDocument = m_pDocument->GetDocument();
         if (!pDocument) return FALSE;
 
         if (nPageNo < 0 || nPageNo >= pDocument->GetPageCount())
         {
-                //sError = JSGetStringFromID(IDS_STRING_JSPARAMERROR);
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         CPDF_Dictionary* pPageDict = pDocument->GetPage(nPageNo);
         if (!pPageDict) return FALSE;
 
         CPDF_Page page;
         page.Load(pDocument, pPageDict);
         page.StartParse();
         page.ParseContent();
@@ skipping 48 matching lines @@
 
         if (!m_pDocument->GetPermissions(FPDFPERM_EXTRACT_ACCESS)) return FALSE;
 
         int nPageNo = params.GetSize() > 0 ? (int)params[0] : 0;
 
         CPDF_Document* pDocument = m_pDocument->GetDocument();
         ASSERT(pDocument != NULL);
 
         if (nPageNo < 0 || nPageNo >= pDocument->GetPageCount())
         {
-                //sError = JSGetStringFromID(IDS_STRING_JSPARAMERROR);
+                CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         CPDF_Dictionary* pPageDict = pDocument->GetPage(nPageNo);
         if (!pPageDict) return FALSE;
 
         CPDF_Page page;
         page.Load(pDocument, pPageDict);
         page.StartParse();
         page.ParseContent();
@@ skipping 243 matching lines @@
 
 void Document::DoAnnotDelay()
 {
         CFX_DWordArray DelArray;
 
         for (int j=DelArray.GetSize()-1; j>=0; j--)
         {
                 m_DelayData.RemoveAt(DelArray[j]);
         }
 }