Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 963103004: Remove getCached* methods from remoting.Identity. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove getCached* methods from remoting.Identity. These methods were introduced before Promises were implemented to simplify code that just needs an email address but wouldn't otherwise need to be written asynchronously. With Promises, asynchronous code reads a lot more naturally, and it's less of a concern. Having explicit accessors for cached state means that there needs to be some (asynchronous) initialization code to save them, which complicates some of the changes I'm planning on making to application start-up. The simplest fix is eliminate them altogether and make all the call-sites asynchronous. Committed: https://crrev.com/7b6ab410b0665dcb84c2818f4453b36f2c5a1e36 Cr-Commit-Position: refs/heads/master@{#318794}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase and jscompile fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -80 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 1 chunk +6 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/host_controller.js View 1 2 2 chunks +20 lines, -17 lines 0 comments Download
M remoting/webapp/crd/js/host_screen.js View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M remoting/webapp/crd/js/identity.js View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M remoting/webapp/crd/js/oauth2.js View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Jamie
PTAL
5 years, 9 months ago (2015-02-28 01:40:26 UTC) #2
kelvinp
lgtm
5 years, 9 months ago (2015-03-02 19:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963103004/20001
5 years, 9 months ago (2015-03-02 19:09:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/29033)
5 years, 9 months ago (2015-03-02 20:14:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963103004/40001
5 years, 9 months ago (2015-03-02 22:24:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 23:11:47 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:12:33 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b6ab410b0665dcb84c2818f4453b36f2c5a1e36
Cr-Commit-Position: refs/heads/master@{#318794}

Powered by Google App Engine
This is Rietveld 408576698