DescriptionRemove getCached* methods from remoting.Identity.
These methods were introduced before Promises were implemented to simplify
code that just needs an email address but wouldn't otherwise need to be
written asynchronously. With Promises, asynchronous code reads a lot more
naturally, and it's less of a concern.
Having explicit accessors for cached state means that there needs to be
some (asynchronous) initialization code to save them, which complicates
some of the changes I'm planning on making to application start-up. The
simplest fix is eliminate them altogether and make all the call-sites
asynchronous.
Committed: https://crrev.com/7b6ab410b0665dcb84c2818f4453b36f2c5a1e36
Cr-Commit-Position: refs/heads/master@{#318794}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase and jscompile fixes. #
Messages
Total messages: 12 (5 generated)
|