Fix touch editing handles not shown after trying overscroll

Fix touch editing handles not shown after trying overscroll

Because for each overscroll session, OverscrollStarted() and
OverscrollCompleted() (in TouchEditableImplAura) are not necessarily
called the same number of times, TouchEditableImplAura could be stuck in
a state of thinking that there is always an scroll in progress which
prevents handles from appearing after a long-press.

BUG=430176
Committed: https://crrev.com/0741c9f30945ad8d1332a41f3d8c8336e2e9912d
Cr-Commit-Position: refs/heads/master@{#319761}

[mohsen, 2015-02-27 18:29:54]

mohsen@chromium.org changed reviewers:
+ sadrul@chromium.org

[mohsen, 2015-02-27 18:29:55]

Please take a look...

[sadrul, 2015-03-02 16:54:39]

Can this have a test?

[mohsen, 2015-03-02 17:41:13]

On 2015/03/02 16:54:39, sadrul wrote:
> Can this have a test?

Since this code will go away in a few weeks after touch selection unification, I
thought it is not worth it to add a test; especially that it would be a
(possibly flaky) browser test. The fix itself seemed important to land before
unification, though. Do you think it needs a test?

[sadrul, 2015-03-04 06:05:00]

On 2015/03/02 17:41:13, mohsen wrote:
> On 2015/03/02 16:54:39, sadrul wrote:
> > Can this have a test?
> 
> Since this code will go away in a few weeks after touch selection unification,
I
> thought it is not worth it to add a test; especially that it would be a
> (possibly flaky) browser test. The fix itself seemed important to land before
> unification, though. Do you think it needs a test?

If we expect this fix to go into a release, then we should have a test coverage
for it (otherwise some other change before the release could break this and we
wouldn't know). It looks like we have some browser-tests for this
touch_editable_impl_aura (and we also have some tests for overscroll). So it
probably shouldn't be too hard to add a test?

[mohsen, 2015-03-04 19:24:29]

OK. That makes sense. Please take another look...

[sadrul, 2015-03-05 10:26:08]

lgtm. Thanks. Would be nice to add a test for fling too.

[mohsen, 2015-03-06 00:09:40]

On 2015/03/05 10:26:08, sadrul wrote:
> lgtm. Thanks. Would be nice to add a test for fling too.

There are a few tests for fling. Do you have any other test in mind?

[mohsen, 2015-03-09 21:25:44]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2015-03-09 21:26:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963103003/20001

[commit-bot: I haz the power, 2015-03-09 23:16:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 23:17:25]

Patchset 2 (id:??) landed as
https://crrev.com/0741c9f30945ad8d1332a41f3d8c8336e2e9912d
Cr-Commit-Position: refs/heads/master@{#319761}