Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: build/android/pylib/device/device_utils_test.py

Issue 963093002: [Android] Check for AC and wireless charging when determining charging state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/device/device_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device/device_utils_test.py
diff --git a/build/android/pylib/device/device_utils_test.py b/build/android/pylib/device/device_utils_test.py
index 1b4d1cf57bae84558ebf48d9c6b5a42c27467c04..b7e807e06d74cf063d247e10b99c93fe870b4b5c 100755
--- a/build/android/pylib/device/device_utils_test.py
+++ b/build/android/pylib/device/device_utils_test.py
@@ -1411,51 +1411,61 @@ class DeviceUtilsGetBatteryInfoTest(DeviceUtilsTest):
self.assertEquals({}, self.device.GetBatteryInfo())
-class DeviceUtilsGetUsbChargingTest(DeviceUtilsTest):
- def testGetUsbCharging_true(self):
+class DeviceUtilsGetChargingTest(DeviceUtilsTest):
+ def testGetCharging_usb(self):
with self.assertCall(
self.call.device.GetBatteryInfo(), {'USB powered': 'true'}):
- self.assertTrue(self.device.GetUsbCharging())
+ self.assertTrue(self.device.GetCharging())
- def testGetUsbCharging_false(self):
+ def testGetCharging_usbFalse(self):
with self.assertCall(
self.call.device.GetBatteryInfo(), {'USB powered': 'false'}):
- self.assertFalse(self.device.GetUsbCharging())
+ self.assertFalse(self.device.GetCharging())
- def testGetUsbCharging_unknown(self):
+ def testGetCharging_ac(self):
with self.assertCall(
self.call.device.GetBatteryInfo(), {'AC powered': 'true'}):
- self.assertFalse(self.device.GetUsbCharging())
+ self.assertTrue(self.device.GetCharging())
+
+ def testGetCharging_wireless(self):
+ with self.assertCall(
+ self.call.device.GetBatteryInfo(), {'Wireless powered': 'true'}):
+ self.assertTrue(self.device.GetCharging())
+
+ def testGetCharging_unknown(self):
+ with self.assertCall(
+ self.call.device.GetBatteryInfo(), {'level': '42'}):
+ self.assertFalse(self.device.GetCharging())
-class DeviceUtilsSetUsbChargingTest(DeviceUtilsTest):
+class DeviceUtilsSetChargingTest(DeviceUtilsTest):
@mock.patch('time.sleep', mock.Mock())
- def testSetUsbCharging_enabled(self):
+ def testSetCharging_enabled(self):
with self.assertCalls(
(self.call.device.FileExists(mock.ANY), True),
- (self.call.device.RunShellCommand(mock.ANY), []),
- (self.call.device.GetUsbCharging(), False),
- (self.call.device.RunShellCommand(mock.ANY), []),
- (self.call.device.GetUsbCharging(), True)):
- self.device.SetUsbCharging(True)
+ (self.call.device.RunShellCommand(mock.ANY, check_return=True), []),
+ (self.call.device.GetCharging(), False),
+ (self.call.device.RunShellCommand(mock.ANY, check_return=True), []),
+ (self.call.device.GetCharging(), True)):
+ self.device.SetCharging(True)
- def testSetUsbCharging_alreadyEnabled(self):
+ def testSetCharging_alreadyEnabled(self):
with self.assertCalls(
(self.call.device.FileExists(mock.ANY), True),
- (self.call.device.RunShellCommand(mock.ANY), []),
- (self.call.device.GetUsbCharging(), True)):
- self.device.SetUsbCharging(True)
+ (self.call.device.RunShellCommand(mock.ANY, check_return=True), []),
+ (self.call.device.GetCharging(), True)):
+ self.device.SetCharging(True)
@mock.patch('time.sleep', mock.Mock())
- def testSetUsbCharging_disabled(self):
+ def testSetCharging_disabled(self):
with self.assertCalls(
(self.call.device.FileExists(mock.ANY), True),
- (self.call.device.RunShellCommand(mock.ANY), []),
- (self.call.device.GetUsbCharging(), True),
- (self.call.device.RunShellCommand(mock.ANY), []),
- (self.call.device.GetUsbCharging(), False)):
- self.device.SetUsbCharging(False)
+ (self.call.device.RunShellCommand(mock.ANY, check_return=True), []),
+ (self.call.device.GetCharging(), True),
+ (self.call.device.RunShellCommand(mock.ANY, check_return=True), []),
+ (self.call.device.GetCharging(), False)):
+ self.device.SetCharging(False)
« no previous file with comments | « build/android/pylib/device/device_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698