Issue 963063003: DDC fixes on DDC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963063003: DDC fixes on DDC (Closed)

Created:
5 years, 9 months ago by vsm

Modified:
5 years, 9 months ago

Reviewers:
Leaf, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

DDC fixes on DDC This isn't everything by far, but most issues local to DDC itself that we mark error right now. There are a bunch of down casts around literals and not-quite-generic methods. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1e62196e4b0c111f9077ad7ad927f2c7c6d2f697

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	lib/config.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/js/printer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/js/template.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/options.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

vsm

5 years, 9 months ago (2015-02-27 18:16:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e62196e4b0c111f9077ad7ad927f2c7c6d2f697 (presubmit successful).