Revert of Add chrome driver to the GN build.

Revert of Add chrome driver to the GN build. (patchset #2 id:20001 of https://codereview.chromium.org/958743003/)

Reason for revert:
Breaks gn builds with os=android.

It would be great to understand why it did not break the bots, though.

Original issue's description:
> Add chrome driver to the GN build.
>
> BUG=
>
> Committed: https://crrev.com/ad912fc2a22d3ddd4c52cb70b487fcb268941ec2
> Cr-Commit-Position: refs/heads/master@{#318272}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/5675f483e005dddc6a6f494c3edb053c1ca25c71
Cr-Commit-Position: refs/heads/master@{#318437}

[mlamouri (slow - plz ping), 2015-02-27 12:27:39]

Created Revert of Add chrome driver to the GN build.

[commit-bot: I haz the power, 2015-02-27 12:28:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/963063002/1

[commit-bot: I haz the power, 2015-02-27 12:29:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-27 12:30:09]

Patchset 1 (id:??) landed as
https://crrev.com/5675f483e005dddc6a6f494c3edb053c1ca25c71
Cr-Commit-Position: refs/heads/master@{#318437}

[brettw, 2015-02-27 19:26:20]

You didn't supply a link to any failure and I see on failures of the
Android GN bot over the past few days:
http://build.chromium.org/p/chromium.linux/builders/Android%20GN?numbuilds=200

What failed?

Brett

On Fri, Feb 27, 2015 at 4:27 AM, <mlamouri@chromium.org> wrote:

> Reviewers: Dirk Pranke, brettw,
>
> Message:
> Created Revert of Add chrome driver to the GN build.
>
> Description:
> Revert of Add chrome driver to the GN build. (patchset #2 id:20001 of
> https://codereview.chromium.org/958743003/)
>
> Reason for revert:
> Breaks gn builds with os=android.
>
> It would be great to understand why it did not break the bots, though.
>
> Original issue's description:
>
>> Add chrome driver to the GN build.
>>
>
>  BUG=
>>
>
>  Committed: https://crrev.com/ad912fc2a22d3ddd4c52cb70b487fcb268941ec2
>> Cr-Commit-Position: refs/heads/master@{#318272}
>>
>
> TBR=dpranke@chromium.org,brettw@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Please review this at https://codereview.chromium.org/963063002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@test_audit
>
> Affected files (+83, -340 lines):
>   M BUILD.gn
>   D chrome/chrome_tests.gni
>   M chrome/chrome_tests.gypi
>   M chrome/test/BUILD.gn
>   D chrome/test/chromedriver/BUILD.gn
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mlamouri (slow - plz ping), 2015-03-02 13:52:16]

The GN bot in Chromium only builds chrome_shell_apk, the error was on another
target. It broke a downstream bot. Otherwise, you can reproduce this error
locally in Chromium by simply building 'All' with a build that has os=android.

[brettw, 2015-03-02 18:42:07]

On 2015/03/02 13:52:16, Mounir Lamouri wrote:
> The GN bot in Chromium only builds chrome_shell_apk, the error was on another
> target. It broke a downstream bot. Otherwise, you can reproduce this error
> locally in Chromium by simply building 'All' with a build that has os=android.

Thanks, I managed to guess about that. In the future, if you revert something,
please provide a link to the failure so it's really clear (even for things that
seem obvious at the time since the patch author may not get back to it for a few
days).