Issue 963043003: Add [TypeChecking=Unrestricted] to OfflineAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963043003: Add [TypeChecking=Unrestricted] to OfflineAudioContext (Closed)

Created:
5 years, 9 months ago by Jens Widell

Modified:
5 years, 9 months ago

Reviewers:
Raymond Toy

CC:
blink-reviews, Raymond Toy

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add [TypeChecking=Unrestricted] to OfflineAudioContext This affects its constructor's 'sampleRate' argument, such that the constructor now throws a TypeError if the argument value is non-finite. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191009

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	LayoutTests/webaudio/offlineaudiocontext-constructor.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/webaudio/OfflineAudioContext.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jens Widell

PTAL Follow-up to https://codereview.chromium.org/927333004/, since I somehow missed that this constructor had a float argument.

5 years, 9 months ago (2015-02-27 13:42:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963043003/1

5 years, 9 months ago (2015-02-27 16:17:28 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-02-27 16:20:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191009

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages