Chromium Code Reviews
Help | Chromium Project | Sign in
(267)

Issue 9630015: Fix licensing information for breakpad/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Steve Block
Modified:
2 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix licensing information for breakpad/

This change adds the required fields to README.chromium and adds a license
file.

The license file contains the license for both breakpad and libcurl (included
by breakpad as a third-party directory) ...
- breakpad - Taken from upstream COPYING at r255. See
http://code.google.com/p/google-breakpad/source/browse/trunk/COPYING?r=255.
Note that this file isn't pulled into Chromium via DEPS as we don't pull the
entire breakpad repository.
- libcurl - Taken from upstream src/third_party/curl/COPYING at r932. See
http://code.google.com/p/google-breakpad/source/browse/trunk/src/third_party/curl/COPYING?r=932.
Note that this file isn't currently in Chromium as we're synced to r922 via
DEPS.

breakpad/ is currently skipped by tools/licenses.py. This exception can't
easily be removed because breakpad/ contains a subdirectory named third_party
which causes the tool to barf.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126088

Patch Set 1 #

Patch Set 2 : Updated to include libcurl license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Lint Patch
A breakpad/LICENSE View 1 1 chunk +51 lines, -0 lines 0 comments ? errors Download
M breakpad/README.chromium View 1 1 chunk +8 lines, -1 line 0 comments ? errors Download
Commit:

Messages

Total messages: 5
Steve Block
2 years, 1 month ago #1
Steve Block
2 years, 1 month ago #2
Mark Mentovai
LGTM
2 years, 1 month ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/9630015/2001
2 years, 1 month ago #4
I haz the power (commit-bot)
2 years, 1 month ago #5
Change committed as 126088
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6