Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 962983002: Convert v8::Value::To* to use MaybeLocal (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert v8::Value::To* to use MaybeLocal BUG=v8:3929 LOG=y Committed: https://crrev.com/2fc51d9cfa8d1b5e1a3a5b82b9af34994e286879 Cr-Commit-Position: refs/heads/master@{#26912}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -122 lines) Patch
M include/v8.h View 1 2 3 6 chunks +50 lines, -1 line 0 comments Download
M include/v8config.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/api.h View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 3 2 chunks +138 lines, -121 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/962983002/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/962983002/diff/40001/include/v8.h#newcode438 include/v8.h:438: V8_INLINE bool ToLocal(Local<S>* out) const { ...
5 years, 9 months ago (2015-02-27 09:42:49 UTC) #2
dcarney
https://codereview.chromium.org/962983002/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/962983002/diff/40001/include/v8.h#newcode438 include/v8.h:438: V8_INLINE bool ToLocal(Local<S>* out) const { On 2015/02/27 09:42:49, ...
5 years, 9 months ago (2015-02-27 09:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962983002/60001
5 years, 9 months ago (2015-02-27 10:16:19 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-02-27 10:39:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 10:39:56 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2fc51d9cfa8d1b5e1a3a5b82b9af34994e286879
Cr-Commit-Position: refs/heads/master@{#26912}

Powered by Google App Engine
This is Rietveld 408576698