Issue 962963008: Add [TypeChecking=Interface] to Animation interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 962963008: Add [TypeChecking=Interface] to Animation interface (Closed)

Created:
5 years, 9 months ago by Jens Widell

Modified:
5 years, 9 months ago

Reviewers:
dstockwell

CC:
dstockwell, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add [TypeChecking=Interface] to Animation interface This affects its constructor, which takes a (nullable) Element argument, and with this change throws a TypeError if the argument value is not null, undefined or an element. Previously it would treat all non-element values as null. BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191532

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/core/animation/Animation.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jens Widell

PTAL This is done so that we can later make [TypeChecking=Interface] on by default, and ...

5 years, 9 months ago (2015-03-03 10:59:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962963008/1

5 years, 9 months ago (2015-03-09 08:34:06 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 10:19:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191532

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages