Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962903003: Rename WebDataServiceBackend to WebDatabaseBackend (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WebDataServiceBackend to WebDatabaseBackend As the comment in web_data_service_backend.h by caitkp@, rename WebDataServiceBackend to WebDatabaseBackend and related class. Rename the files also. BUG= R=caitkp@chromium.org Committed: https://crrev.com/311c8fce7a78c9310f2b6f2e351d4b70bc506a35 Cr-Commit-Position: refs/heads/master@{#320638}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase and fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -325 lines) Patch
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/webdata.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D components/webdata/common/web_data_service_backend.h View 1 chunk +0 lines, -129 lines 0 comments Download
D components/webdata/common/web_data_service_backend.cc View 1 chunk +0 lines, -119 lines 0 comments Download
A + components/webdata/common/web_database_backend.h View 1 6 chunks +17 lines, -21 lines 0 comments Download
A + components/webdata/common/web_database_backend.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M components/webdata/common/web_database_service.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/webdata/common/web_database_service.cc View 1 4 chunks +26 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-27 01:51:04 UTC) #1
zhuoyu.qian
Hi Cait, Please take a look this CL, Thank you!
5 years, 9 months ago (2015-03-11 07:59:27 UTC) #2
Cait (Slow)
Thank you for taking on this clean-up! looks good overall, just a couple of nits. ...
5 years, 9 months ago (2015-03-11 14:49:27 UTC) #3
Cait (Slow)
Also, you'll probably want to kick off a round of try jobs, just to make ...
5 years, 9 months ago (2015-03-11 14:51:17 UTC) #4
zhuoyu.qian
Hi Cait: I submitted a new patch set for fix nits, please have another look. ...
5 years, 9 months ago (2015-03-12 01:50:09 UTC) #5
Cait (Slow)
lgtm Thanks for the clean-up!
5 years, 9 months ago (2015-03-13 15:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962903003/20001
5 years, 9 months ago (2015-03-14 02:00:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-14 03:50:25 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 03:51:03 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/311c8fce7a78c9310f2b6f2e351d4b70bc506a35
Cr-Commit-Position: refs/heads/master@{#320638}

Powered by Google App Engine
This is Rietveld 408576698