UI impl side painting default on

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 562 matching lines @@
   use_image_texture_target_ = GL_TEXTURE_2D;
   if (command_line.HasSwitch(switches::kUseImageTextureTarget)) {
     std::string target_string =
         command_line.GetSwitchValueASCII(switches::kUseImageTextureTarget);
     const unsigned targets[] = {
       GL_TEXTURE_RECTANGLE_ARB,
       GL_TEXTURE_EXTERNAL_OES
     };
     for (auto target : targets) {
       if (target_string == gpu::gles2::GLES2Util::GetStringEnum(target))
         use_image_texture_target_ = target;

[reveman, 2015/02/27 17:34:15]

Btw, we need to make sure LayerTreeSettings::use_image_texture_target is set
correctly for the browser compositor. The logic that determines what the value
of that field needs to be can be found here:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

I guess we need to move some of that code to compositor_util.cc..

     }
   }
 
   if (command_line.HasSwitch(switches::kDisableLCDText)) {
     is_lcd_text_enabled_ = false;
   } else if (command_line.HasSwitch(switches::kEnableLCDText)) {
     is_lcd_text_enabled_ = true;
   } else {
 #if defined(OS_ANDROID)
     is_lcd_text_enabled_ = false;
@@ skipping 68 matching lines @@
     bool parsed_num_raster_threads =
         base::StringToInt(string_value, &num_raster_threads);
     DCHECK(parsed_num_raster_threads) << string_value;
     DCHECK_GT(num_raster_threads, 0);
 
     // Force maximum 1 thread for threaded GPU rasterization.
     // TODO(vmiura): crbug.com/459760 Support existence of multiple raster
     // threads in GPU raster mode.
     if (is_threaded_gpu_rasterization_enabled_)
       num_raster_threads = 1;
-    cc::TileTaskWorkerPool::SetNumWorkerThreads(num_raster_threads);
+
+    if (!command_line.HasSwitch(switches::kSingleProcess))

[reveman, 2015/02/27 17:34:15]

We need to call SetNumWorkerThreads in the browser process prior to creating the
browser compositor. And I think it would be nice with a comment making it clear
that this is not needed in single process mode because we've already set it for
the browser compositor.

+      cc::TileTaskWorkerPool::SetNumWorkerThreads(num_raster_threads);
 
 #if defined(OS_ANDROID) || defined(OS_LINUX)
     if (!command_line.HasSwitch(
             switches::kUseNormalPriorityForTileTaskWorkerThreads)) {
       cc::TileTaskWorkerPool::SetWorkerThreadPriority(
           base::kThreadPriority_Background);
     }
 #endif
   }
 
@@ skipping 1144 matching lines @@
     mojo::InterfaceRequest<mojo::ServiceProvider> services,
     mojo::ServiceProviderPtr exposed_services)
     : services(services.Pass()),
       exposed_services(exposed_services.Pass()) {
 }
 
 RenderThreadImpl::PendingRenderFrameConnect::~PendingRenderFrameConnect() {
 }
 
 }  // namespace content