Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 962793007: Add [TypeChecking=Unrestricted] to CircularGeofencingRegionInit (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] to CircularGeofencingRegionInit This will make the CircularGeofencingRegion constructor throw TypeError when called with a dictionary containing non-finite numbers. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/modules/geofencing/CircularGeofencingRegionInit.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL I couldn't find a specification, so I have no idea if this matches it. ...
5 years, 9 months ago (2015-02-27 10:56:56 UTC) #2
Marijn Kruisselbrink
On 2015/02/27 10:56:56, Jens Widell wrote: > PTAL > > I couldn't find a specification, ...
5 years, 9 months ago (2015-02-27 18:23:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962793007/1
5 years, 9 months ago (2015-02-27 19:35:04 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 19:37:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191020

Powered by Google App Engine
This is Rietveld 408576698