tools/perf/measurements/page_cycler.py - Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index ce1dc973efeac9a7c7546a51785b432dbbef7c91..b7e2c897a2c6c24882475a75e9b3dc83a1adefb5 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -61,8 +61,6 @@ class PageCycler(page_test.PageTest):

(int(pageset_repeat) - 1) * (100 - cold_load_percent) / 100)

number_warm_runs = number_warm_pageset_runs * page_repeat

self._cold_run_start_index = number_warm_runs + page_repeat

- self._discard_first_result = (not cold_load_percent or

- self._discard_first_result)

else:

self._cold_run_start_index = pageset_repeat * page_repeat

« no previous file with comments | « tools/perf/benchmarks/startup.py ('k') | tools/perf/measurements/startup.py » ('j') | no next file with comments »