Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/session_restore.py » ('j') | tools/perf/benchmarks/startup.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index c4837d0fce2fbd2bf70499054ce112137edf28c5..df4f46d0d3696b081e7c5b45942577f3c739bb76 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -23,6 +23,10 @@ class _PageCycler(benchmark.Benchmark):
parser.add_option('--cold-load-percent', type='int', default=50,
help='%d of page visits for which a cold load is forced')
+ @classmethod
+ def ProcessCommandLineArgs(cls, parser, args):
nednguyen 2015/02/27 13:27:35 Don't you need to call super class' ProcessCommand
+ args.discard_first_result = args.cold_load_percent == 0
+
def CreatePageTest(self, options):
return page_cycler.PageCycler(
page_repeat = options.page_repeat,
@@ -219,3 +223,4 @@ class PageCyclerBigJs(_PageCycler):
def Name(cls):
return 'page_cycler.big_js'
+
« no previous file with comments | « no previous file | tools/perf/benchmarks/session_restore.py » ('j') | tools/perf/benchmarks/startup.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698