Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 962783002: Adding a page cycler becnchmark for measuring out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move oopif benchmark over to the main page_cycler file. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index c4837d0fce2fbd2bf70499054ce112137edf28c5..770aed33d112c6ad38c08401840fd6d07e141c0f 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -195,7 +195,7 @@ class PageCyclerToughLayoutCases(_PageCycler):
return 'page_cycler.tough_layout_cases'
-# crbug.com/273986: This test is really flakey on xp.
+# crbug.com/273986: This test is flakey on Windows.
@benchmark.Disabled('win')
class PageCyclerTypical25(_PageCycler):
"""Page load time benchmark for a 25 typical web pages.
@@ -211,6 +211,21 @@ class PageCyclerTypical25(_PageCycler):
def CreatePageSet(self, options):
return page_sets.Typical25PageSet(run_no_page_interactions=True)
+# crbug.com/273986: This test is flakey on Windows.
+@benchmark.Disabled('win')
+class PageCyclerOopifTypical25(_PageCycler):
+ """ A varation of the benchmark above, but running in --site-per-process
+ to allow measuring performance of out-of-process iframes.
+ """
+ @classmethod
+ def Name(cls):
+ return 'page_cycler_oopif.typical_25'
+
+ def CustomizeBrowserOptions(self, options):
+ options.AppendExtraBrowserArgs(['--site-per-process'])
+
+ def CreatePageSet(self, options):
+ return page_sets.Typical25PageSet(run_no_page_interactions=True)
@benchmark.Disabled # crbug.com/443730
class PageCyclerBigJs(_PageCycler):
@@ -218,4 +233,3 @@ class PageCyclerBigJs(_PageCycler):
@classmethod
def Name(cls):
return 'page_cycler.big_js'
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698