Source/core/layout/style/SVGLayoutStyleDefs.cpp - Issue 962763003: Use Length for the stroke-dashoffset property in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/style/SVGLayoutStyleDefs.cpp

Issue 962763003: Use Length for the stroke-dashoffset property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make font-size explicit. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/style/SVGLayoutStyleDefs.cpp

diff --git a/Source/core/layout/style/SVGLayoutStyleDefs.cpp b/Source/core/layout/style/SVGLayoutStyleDefs.cpp

index 7ebb06c64597c57a5d15ef6ceea37765697fd0a9..2419eef65fff757987b12724d9c94296b672bc18 100644

--- a/Source/core/layout/style/SVGLayoutStyleDefs.cpp

+++ b/Source/core/layout/style/SVGLayoutStyleDefs.cpp

@@ -86,7 +86,7 @@ StyleStrokeData::StyleStrokeData(const StyleStrokeData& other)

, opacity(other.opacity)

, miterLimit(other.miterLimit)

, width(other.width->clone())

- , dashOffset(other.dashOffset->clone())

+ , dashOffset(other.dashOffset)

, dashArray(other.dashArray->clone())

, paintType(other.paintType)

, paintColor(other.paintColor)

@@ -102,7 +102,7 @@ bool StyleStrokeData::operator==(const StyleStrokeData& other) const

return *width == *other.width

&& opacity == other.opacity

&& miterLimit == other.miterLimit

- && *dashOffset == *other.dashOffset

+ && dashOffset == other.dashOffset

&& *dashArray == *other.dashArray

&& paintType == other.paintType

&& paintColor == other.paintColor