Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10332)

Unified Diff: chrome/common/terminate_on_heap_corruption_experiment_win.cc

Issue 962753002: Revert the TerminateOnHeapCorruption experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/terminate_on_heap_corruption_experiment_win.h ('k') | content/app/content_main_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/terminate_on_heap_corruption_experiment_win.cc
diff --git a/chrome/common/terminate_on_heap_corruption_experiment_win.cc b/chrome/common/terminate_on_heap_corruption_experiment_win.cc
deleted file mode 100644
index a4dde265f5ffe2c01e57c24cdd31c664f09edbe5..0000000000000000000000000000000000000000
--- a/chrome/common/terminate_on_heap_corruption_experiment_win.cc
+++ /dev/null
@@ -1,56 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/terminate_on_heap_corruption_experiment_win.h"
-
-#include "base/command_line.h"
-#include "base/metrics/field_trial.h"
-#include "base/win/registry.h"
-#include "chrome/common/chrome_constants.h"
-#include "chrome/common/chrome_version_info.h"
-
-namespace {
-
-const wchar_t* GetBeaconKeyPath() {
- chrome::VersionInfo::Channel channel = chrome::VersionInfo::CHANNEL_UNKNOWN;
-
- // We are called quite early, before the CommandLine is initialized. We don't
- // want to permanently initialize it because ContentMainRunner::Initialize
- // sets some locale-related stuff to make sure it is parsed properly. But we
- // can temporarily initialize it for the purpose of determining if we are
- // Canary.
- if (!base::CommandLine::InitializedForCurrentProcess()) {
- base::CommandLine::Init(0, NULL);
- channel = chrome::VersionInfo::GetChannel();
- base::CommandLine::Reset();
- } else {
- channel = chrome::VersionInfo::GetChannel();
- }
-
- if (channel == chrome::VersionInfo::CHANNEL_CANARY) {
- return L"SOFTWARE\\" PRODUCT_STRING_PATH
- L"\\DisableTerminateOnProcessHeapCorruptionSxs";
- }
- return L"SOFTWARE\\" PRODUCT_STRING_PATH
- L"\\DisableTerminateOnProcessHeapCorruption";
-}
-
-} // namespace
-
-bool ShouldExperimentallyDisableTerminateOnHeapCorruption() {
- base::win::RegKey regkey(
- HKEY_CURRENT_USER, GetBeaconKeyPath(), KEY_QUERY_VALUE);
- return regkey.Valid();
-}
-
-void InitializeDisableTerminateOnHeapCorruptionExperiment() {
- base::win::RegKey regkey(HKEY_CURRENT_USER);
-
- if (base::FieldTrialList::FindFullName("TerminateOnProcessHeapCorruption") ==
- "Disabled") {
- regkey.CreateKey(GetBeaconKeyPath(), KEY_SET_VALUE);
- } else {
- regkey.DeleteKey(GetBeaconKeyPath());
- }
-}
« no previous file with comments | « chrome/common/terminate_on_heap_corruption_experiment_win.h ('k') | content/app/content_main_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698