Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 962753002: Revert the TerminateOnHeapCorruption experiment. (Closed)

Created:
5 years, 10 months ago by erikwright (departed)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, robertshield, Sigurður Ásgeirsson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert the TerminateOnHeapCorruption experiment. BUG=394842 Committed: https://crrev.com/23af4fac97bfc9d50bd41414d3ef36f56fb0d5b3 Cr-Commit-Position: refs/heads/master@{#320118}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -96 lines) Patch
M chrome/app/chrome_main_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/terminate_on_heap_corruption_experiment_win.h View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/common/terminate_on_heap_corruption_experiment_win.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M content/app/content_main_runner.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/app/content_main_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
erikwright (departed)
jochen: PTAL for chrome/* brettw: PTAL for content/* siggi: FYI. This reverts the experimental code ...
5 years, 10 months ago (2015-02-26 18:06:36 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-02-27 09:04:57 UTC) #4
erikwright (departed)
brettw: ping
5 years, 9 months ago (2015-03-03 16:04:28 UTC) #5
erikwright (departed)
brettw: ping.
5 years, 9 months ago (2015-03-10 13:32:46 UTC) #6
jochen (gone - plz use gerrit)
On 2015/03/10 at 13:32:46, erikwright wrote: > brettw: ping. i'm also a content owner btw
5 years, 9 months ago (2015-03-11 15:59:15 UTC) #7
erikwright (departed)
On 2015/03/11 15:59:15, jochen (slow) wrote: > On 2015/03/10 at 13:32:46, erikwright wrote: > > ...
5 years, 9 months ago (2015-03-11 18:01:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962753002/1
5 years, 9 months ago (2015-03-11 18:02:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/4385)
5 years, 9 months ago (2015-03-11 18:08:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962753002/20001
5 years, 9 months ago (2015-03-11 18:12:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 19:43:41 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:44:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23af4fac97bfc9d50bd41414d3ef36f56fb0d5b3
Cr-Commit-Position: refs/heads/master@{#320118}

Powered by Google App Engine
This is Rietveld 408576698