Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mcasas@comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index 2acbc6356399a37b7ac65b97a4f2a95461dddfeb..98c1497d1a9e96cac3cdde33213d732e2be5ec78 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -3367,6 +3367,13 @@ TEST_F(GLES2ImplementationTest, CreateAndConsumeTextureCHROMIUM) {
EXPECT_EQ(kTexturesStartId, id);
}
+TEST_F(GLES2ImplementationTest, FailCreateImageCHROMIUMOnEmptyBuffers) {
reveman 2015/03/02 20:09:56 Do we need an error for this? We used to crash if
+ EXPECT_CALL(*command_buffer(), OnFlush()).Times(1).RetiresOnSaturation();
+ GLuint image_id = gl_->CreateImageCHROMIUM(nullptr, 10, 10, GL_RGBA);
+ EXPECT_EQ(0u, image_id);
+ EXPECT_EQ(static_cast<GLenum>(GL_INVALID_VALUE), gl_->GetError());
+}
+
TEST_F(GLES2ImplementationTest, ProduceTextureCHROMIUM) {
struct Cmds {
cmds::ProduceTextureCHROMIUMImmediate cmd;

Powered by Google App Engine
This is Rietveld 408576698