Change CHROMIUM_image declarations to support multi planar input.

cc/resources/resource_provider.cc

Index: cc/resources/resource_provider.cc
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc
index 115238f73cb5e74f32e666db16abc4ff276bf244..895a4e2791a245df4fb221785195146625109b40 100644
--- a/cc/resources/resource_provider.cc
+++ b/cc/resources/resource_provider.cc
@@ -1086,11 +1086,9 @@ ResourceProvider::ScopedWriteLockGpuMemoryBuffer::
     DCHECK_EQ(gpu_memory_buffer_->GetHandle().type, gfx::SHARED_MEMORY_BUFFER);
 #endif
 
-    resource_->image_id =
-        gl->CreateImageCHROMIUM(gpu_memory_buffer_->AsClientBuffer(),
-                                size_.width(),
-                                size_.height(),
-                                GL_RGBA);
+    const ClientBuffer& client_buffer = gpu_memory_buffer_->AsClientBuffer();

[reveman, 2015/03/02 20:09:55]

why a const ref? is this temporary variable needed at all? can we just do
"&gpu_memory_buffer_->AsClientBuffer()" below instead?

[emircan, 2015/03/03 02:02:18]

The temporaray is an rvalue and throws the error below. This is to turn it into
an lvalue.

http://thbecker.net/articles/rvalue_references/section_01.html

../../cc/resources/resource_provider.cc:1090:51: error: cannot take the address
of an rvalue of type 'ClientBuffer' (aka '_ClientBuffer *')
    resource_->image_id =
gl->CreateImageCHROMIUM(&(gpu_memory_buffer_->AsClientBuffer()), size_.width(),

[reveman, 2015/03/03 05:30:13]

Ok, how about this:

ClientBuffer buffers[] = {
  gpu_memory_buffer_->AsClientBuffer()
};
CreateImageCHROMIUM(buffers, ...);

makes it more clear that we're passing an array with one buffer to CreateImage.

[emircan, 2015/03/04 03:03:15]

Done.

+    resource_->image_id = gl->CreateImageCHROMIUM(&client_buffer, size_.width(),
+                                                  size_.height(), GL_RGBA);
   }
 
   std::swap(resource_->gpu_memory_buffer, gpu_memory_buffer_);