content/common/gpu/gpu_messages.h - Issue 962723002: Change CHROMIUM_image declarations to support multi planar input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_messages.h

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle through IPC. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/gpu_command_buffer_stub.cc ('K') | « content/common/gpu/gpu_command_buffer_stub.cc ('k') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt » ('j') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_messages.h

diff --git a/content/common/gpu/gpu_messages.h b/content/common/gpu/gpu_messages.h

index 5026150b802bb909ca3d615649d6328069068844..e3d1c2ae7f3436d9d7ea125cb32c17d52e233aed 100644

--- a/content/common/gpu/gpu_messages.h

+++ b/content/common/gpu/gpu_messages.h

@@ -610,9 +610,9 @@ IPC_MESSAGE_ROUTED2(GpuCommandBufferMsg_SignalQuery,

// used to identify the image from a command buffer.

IPC_MESSAGE_ROUTED5(GpuCommandBufferMsg_CreateImage,

int32 /* id */,

- gfx::GpuMemoryBufferHandle /* gpu_memory_buffer */,

+ gfx::GpuMemoryBufferHandle* /* gpu_memory_buffer */,

reveman 2015/03/04 05:56:00 You can't pass pointers with IPC messages. You nee

emircan 2015/03/04 23:31:50 Changed it to std::vector<gfx::GpuMemoryBufferHand

gfx::Size /* size */,

- gfx::GpuMemoryBuffer::Format /* format */,

+ gfx::GpuMemoryBuffer::Format* /* format */,

reveman 2015/03/04 05:56:00 ditto.

emircan 2015/03/04 23:31:50 Changed it to std::vector<GpuMemoryBuffer::Format>

uint32 /* internalformat */)

// Destroy a previously created image.