gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc - Issue 962723002: Change CHROMIUM_image declarations to support multi planar input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reveman@ comments and const-corrected function signatures. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt ('K') | « gpu/command_buffer/service/in_process_command_buffer.cc ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

index 8430dfb9eb45fe84585d2a144dc2ece65c9e8362..32f1ecf2013462d7332cf07b52c960bfb7d244f2 100644

--- a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

+++ b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

@@ -96,8 +96,10 @@ TEST_F(GpuMemoryBufferTest, Lifecycle) {

buffer->Unmap();

// Create the image. This should add the image ID to the ImageManager.

+ ClientBuffer client_buffer = buffer->AsClientBuffer();

GLuint image_id = glCreateImageCHROMIUM(

- buffer->AsClientBuffer(), kImageWidth, kImageHeight, GL_RGBA);

+ const_cast<const ClientBuffer* const>(&client_buffer), kImageWidth,

+ kImageHeight, GL_RGBA);

EXPECT_NE(0u, image_id);

EXPECT_TRUE(gl_.decoder()->GetImageManager()->LookupImage(image_id) != NULL);