gpu/command_buffer/client/gles2_implementation_unittest.cc - Issue 962723002: Change CHROMIUM_image declarations to support multi planar input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reveman@ comments and const-corrected function signatures. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt ('K') | « gpu/command_buffer/client/gles2_implementation_autogen.h ('k') | gpu/command_buffer/client/gles2_interface_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/gles2_implementation_unittest.cc

diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc

index 2acbc6356399a37b7ac65b97a4f2a95461dddfeb..98c1497d1a9e96cac3cdde33213d732e2be5ec78 100644

--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc

+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc

@@ -3367,6 +3367,13 @@ TEST_F(GLES2ImplementationTest, CreateAndConsumeTextureCHROMIUM) {

EXPECT_EQ(kTexturesStartId, id);

}

+TEST_F(GLES2ImplementationTest, FailCreateImageCHROMIUMOnEmptyBuffers) {

+ EXPECT_CALL(*command_buffer(), OnFlush()).Times(1).RetiresOnSaturation();

+ GLuint image_id = gl_->CreateImageCHROMIUM(nullptr, 10, 10, GL_RGBA);

+ EXPECT_EQ(0u, image_id);

+ EXPECT_EQ(static_cast<GLenum>(GL_INVALID_VALUE), gl_->GetError());

TEST_F(GLES2ImplementationTest, ProduceTextureCHROMIUM) {

struct Cmds {

cmds::ProduceTextureCHROMIUMImmediate cmd;