Change CHROMIUM_image declarations to support multi planar input.

gpu/command_buffer/service/image_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_
 #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_
 
 #include "base/memory/ref_counted.h"
 #include "gpu/gpu_export.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 
 namespace gfx {
 class GLImage;
 }
 
 namespace gpu {
 
 class GPU_EXPORT ImageFactory {
  public:
   ImageFactory();
 
-  // Returns a valid GpuMemoryBuffer format given a valid internalformat as
-  // defined by CHROMIUM_gpu_memory_buffer_image.
-  static gfx::GpuMemoryBuffer::Format ImageFormatToGpuMemoryBufferFormat(
-      unsigned internalformat);
+  // Returns the number of GpuMemoryBuffers used when given a valid
+  // |internalformat| as defined by CHROMIUM_gpu_memory_buffer_image.
+  static int GpuMemoryBufferCountForImageFormat(unsigned internalformat);
+
+  // Fills a vector of valid GpuMemoryBuffer formats in |formats| when given a
+  // valid |internalformat| as defined by CHROMIUM_gpu_memory_buffer_image.
+  static void ImageFormatToGpuMemoryBufferFormats(
+      unsigned internalformat,
+      std::vector<gfx::GpuMemoryBuffer::Format>* formats);
 
   // Returns a valid GpuMemoryBuffer usage given a valid usage as defined by
   // CHROMIUM_gpu_memory_buffer_image.
   static gfx::GpuMemoryBuffer::Usage ImageUsageToGpuMemoryBufferUsage(
       unsigned usage);
 
   // Returns true if |internalformat| is compatible with |format|.
   static bool IsImageFormatCompatibleWithGpuMemoryBufferFormat(

[reveman, 2015/03/05 19:35:32]

Doesn't this need a buffer index or something? How would this otherwise work
with GL_RGB_YUV420?

[emircan, 2015/03/09 21:07:22]

I was initially thinking the ordering of the buffer elements wouldn't matter and
we can rearrange them according to the formats defined. Such that for
GL_RGB_YUV420, it can be {U_2, V_2, Y_8}, etc. 

I took you advice and added the index instead, so that we can force the order.

       unsigned internalformat,
       gfx::GpuMemoryBuffer::Format format);
 
   // Creates a GLImage instance for GPU memory buffer identified by |handle|.
   // |client_id| should be set to the client requesting the creation of instance
   // and can be used by factory implementation to verify access rights.
   virtual scoped_refptr<gfx::GLImage> CreateImageForGpuMemoryBuffer(

[reveman, 2015/03/05 19:35:32]

CreateImageForGpuMemoryBuffers

[emircan, 2015/03/09 21:07:23]

Done. Sorry for missing that.

-      const gfx::GpuMemoryBufferHandle& handle,
+      const std::vector<gfx::GpuMemoryBufferHandle>& handles,
       const gfx::Size& size,
-      gfx::GpuMemoryBuffer::Format format,
+      const std::vector<gfx::GpuMemoryBuffer::Format>& formats,
       unsigned internalformat,
       int client_id) = 0;
 
  protected:
   virtual ~ImageFactory();
 };
 
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_