Change CHROMIUM_image declarations to support multi planar input.

content/common/gpu/client/command_buffer_proxy_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/command_buffer_proxy_impl.h"
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
 #include "base/stl_util.h"
@@ skipping 329 matching lines @@
   if (last_state_.error != gpu::error::kNoError)
     return;
 
   Send(new GpuCommandBufferMsg_DestroyTransferBuffer(route_id_, id));
 }
 
 gpu::Capabilities CommandBufferProxyImpl::GetCapabilities() {
   return capabilities_;
 }
 
-int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer buffer,
+int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer* const buffers,
                                             size_t width,
                                             size_t height,
                                             unsigned internalformat) {
   CheckLock();
   if (last_state_.error != gpu::error::kNoError)
     return -1;
 
   int32 new_id = channel_->ReserveImageId();
 
   gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager =
       channel_->gpu_memory_buffer_manager();
-  gfx::GpuMemoryBuffer* gpu_memory_buffer =
-      gpu_memory_buffer_manager->GpuMemoryBufferFromClientBuffer(buffer);
-  DCHECK(gpu_memory_buffer);
 
-  // This handle is owned by the GPU process and must be passed to it or it
-  // will leak. In otherwords, do not early out on error between here and the
-  // sending of the CreateImage IPC below.
-  bool requires_sync_point = false;
-  gfx::GpuMemoryBufferHandle handle =
-      channel_->ShareGpuMemoryBufferToGpuProcess(gpu_memory_buffer->GetHandle(),
-                                                 &requires_sync_point);
+  int num_buffers =
+      gpu::ImageFactory::GpuMemoryBufferCountForImageFormat(internalformat);
 
-  DCHECK(gpu::ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(
-      internalformat, gpu_memory_buffer->GetFormat()));
+  gfx::GpuMemoryBuffer* gpu_memory_buffers[num_buffers];

[reveman, 2015/03/05 19:35:32]

nit: please avoid this array and use a temporary variable in both loops instead.

[emircan, 2015/03/09 21:07:22]

Done.

+  std::vector<gfx::GpuMemoryBufferHandle> handles(num_buffers);

[reveman, 2015/03/05 19:35:32]

nit: I prefer if this is empty initially and instead grew by using push_back

[emircan, 2015/03/09 21:07:22]

Done.

+  std::vector<gfx::GpuMemoryBuffer::Format> formats(num_buffers);

[reveman, 2015/03/05 19:35:32]

ditto

[emircan, 2015/03/09 21:07:22]

Done.

+  bool requires_sync_point[num_buffers];

[reveman, 2015/03/05 19:35:32]

You can skip this array and simply set a destruction sync point on all buffers
if one happen to require one.

[emircan, 2015/03/09 21:07:22]

Done.

+  for (int i = 0; i < num_buffers; ++i) {
+    gpu_memory_buffers[i] =
+        gpu_memory_buffer_manager->GpuMemoryBufferFromClientBuffer(buffers[i]);
+    DCHECK(gpu_memory_buffers[i]);
+
+    formats[i] = gpu_memory_buffers[i]->GetFormat();
+    DCHECK(gpu::ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(
+        internalformat, formats[i]));
+
+    requires_sync_point[i] = false;
+
+    // This handle is owned by the GPU process and must be passed to it or it
+    // will leak. In other words, do not early out on error between here and the
+    // sending of the CreateImage IPC below.
+    handles[i] = channel_->ShareGpuMemoryBufferToGpuProcess(
+        gpu_memory_buffers[i]->GetHandle(), &requires_sync_point[i]);
+  }
+
   if (!Send(new GpuCommandBufferMsg_CreateImage(route_id_,
                                                 new_id,
-                                                handle,
+                                                handles,
                                                 gfx::Size(width, height),
-                                                gpu_memory_buffer->GetFormat(),
+                                                formats,
                                                 internalformat))) {
     return -1;
   }
 
-  if (requires_sync_point) {
-    gpu_memory_buffer_manager->SetDestructionSyncPoint(gpu_memory_buffer,
-                                                       InsertSyncPoint());
+  for (int i = 0; i < num_buffers; ++i) {
+    if (requires_sync_point[i]) {
+      gpu_memory_buffer_manager->SetDestructionSyncPoint(gpu_memory_buffers[i],
+                                                         InsertSyncPoint());

[reveman, 2015/03/05 19:35:32]

Each sync point has a significant cost. Please avoid creating one per buffer.
Just one that is shared between all buffers is enough.

[emircan, 2015/03/09 21:07:22]

Done.

+    }
   }
 
   return new_id;
 }
 
 void CommandBufferProxyImpl::DestroyImage(int32 id) {
   CheckLock();
   if (last_state_.error != gpu::error::kNoError)
     return;
 
   Send(new GpuCommandBufferMsg_DestroyImage(route_id_, id));
 }
 
 int32_t CommandBufferProxyImpl::CreateGpuMemoryBufferImage(
     size_t width,
     size_t height,
     unsigned internalformat,
     unsigned usage) {
   CheckLock();
-  scoped_ptr<gfx::GpuMemoryBuffer> buffer(
-      channel_->gpu_memory_buffer_manager()->AllocateGpuMemoryBuffer(
-          gfx::Size(width, height),
-          gpu::ImageFactory::ImageFormatToGpuMemoryBufferFormat(internalformat),
-          gpu::ImageFactory::ImageUsageToGpuMemoryBufferUsage(usage)));
-  if (!buffer)
-    return -1;
 
-  return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);
+  std::vector<gfx::GpuMemoryBuffer::Format> gpu_memory_buffer_formats;
+  gpu::ImageFactory::ImageFormatToGpuMemoryBufferFormats(

[reveman, 2015/03/05 19:35:32]

If you had a gpu::ImageFactory::ImageFormatToGpuMemoryBufferFormat(GLenum
internalformat, int buffer) function then you wouldn't need this vector and
could just call it from within the loop below instead.

[emircan, 2015/03/09 21:07:22]

Done.

+      internalformat, &gpu_memory_buffer_formats);
+  int num_buffers = gpu_memory_buffer_formats.size();

[reveman, 2015/03/05 19:35:32]

I prefer if you use gpu::ImageFactory::GpuMemoryBufferCountForImageFormat here
instead for consistency with the above code.

[emircan, 2015/03/09 21:07:22]

Done.

+
+  DCHECK_GE(num_buffers, 1);
+
+  ScopedVector<gfx::GpuMemoryBuffer> buffers;
+  ClientBuffer client_buffers[num_buffers];
+  for (int i = 0; i < num_buffers; ++i) {
+    buffers.push_back(
+        channel_->gpu_memory_buffer_manager()->AllocateGpuMemoryBuffer(
+            gfx::Size(width, height), gpu_memory_buffer_formats[i],
+            gpu::ImageFactory::ImageUsageToGpuMemoryBufferUsage(usage)));
+
+    if (!buffers[i])
+      return -1;
+
+    client_buffers[i] = buffers[i]->AsClientBuffer();
+  }
+  return CreateImage(client_buffers, width, height, internalformat);
 }
 
 int CommandBufferProxyImpl::GetRouteID() const {
   return route_id_;
 }
 
 uint32 CommandBufferProxyImpl::CreateStreamTexture(uint32 texture_id) {
   CheckLock();
   if (last_state_.error != gpu::error::kNoError)
     return 0;
@@ skipping 176 matching lines @@
   }
 }
 
 void CommandBufferProxyImpl::OnUpdateVSyncParameters(base::TimeTicks timebase,
                                                      base::TimeDelta interval) {
   if (!update_vsync_parameters_completion_callback_.is_null())
     update_vsync_parameters_completion_callback_.Run(timebase, interval);
 }
 
 }  // namespace content