Change CHROMIUM_image declarations to support multi planar input.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/hash.h"
 #include "base/json/json_writer.h"
 #include "base/memory/shared_memory.h"
@@ skipping 945 matching lines @@
     if (!memory_manager_client_state_) {
       memory_manager_client_state_.reset(GetMemoryManager()->CreateClientState(
           this, surface_id_ != 0, true));
     }
   } else {
     memory_manager_client_state_.reset();
   }
 }
 
 void GpuCommandBufferStub::OnCreateImage(int32 id,
-                                         gfx::GpuMemoryBufferHandle handle,
+                                         gfx::GpuMemoryBufferHandle* handles,

[reveman, 2015/03/04 05:56:00]

Receiving pointers over IPC doesn't work.

                                          gfx::Size size,
-                                         gfx::GpuMemoryBuffer::Format format,
+                                         gfx::GpuMemoryBuffer::Format* formats,

[reveman, 2015/03/04 05:56:00]

ditto

                                          uint32 internalformat) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnCreateImage");
 
   if (!decoder_)
     return;
 
   gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
   DCHECK(image_manager);
   if (image_manager->LookupImage(id)) {
     LOG(ERROR) << "Image already exists with same ID.";
     return;
   }
 
-  if (!IsSupportedImageFormat(decoder_->GetCapabilities(), format)) {
-    LOG(ERROR) << "Image format is not supported.";
-    return;
+  int num_buffers =
+      gpu::ImageFactory::GpuMemoryBufferCountForImageFormat(internalformat);
+
+  for (int i = 0; i < num_buffers; ++i) {
+    if (!IsSupportedImageFormat(decoder_->GetCapabilities(), formats[i])) {
+      LOG(ERROR) << "Image format is not supported.";
+      return;
+    }
   }
 
+  // TODO(emircan): See http://crbug.com/439520; support passing multiple
+  // buffers when new multi-planar formats are added.
   scoped_refptr<gfx::GLImage> image = channel()->CreateImageForGpuMemoryBuffer(
-      handle, size, format, internalformat);
+      handles[0], size, formats[0], internalformat);

[reveman, 2015/03/04 05:56:00]

Don't stop here :)

[emircan, 2015/03/04 23:31:50]

Went ahead, until the modification of gfx::GLImageSharedMemory::Initialize. Do
you think we should leave that part to next CLs?

   if (!image.get())
     return;
 
   image_manager->AddImage(image.get(), id);
 }
 
 void GpuCommandBufferStub::OnDestroyImage(int32 id) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyImage");
 
   if (!decoder_)
@@ skipping 112 matching lines @@
   Send(new GpuCommandBufferMsg_SwapBuffersCompleted(route_id_, latency_info));
 }
 
 void GpuCommandBufferStub::SendUpdateVSyncParameters(base::TimeTicks timebase,
                                                      base::TimeDelta interval) {
   Send(new GpuCommandBufferMsg_UpdateVSyncParameters(route_id_, timebase,
                                                      interval));
 }
 
 }  // namespace content