Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 962703004: Add "force inline" to internal annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/js_lib/annotations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 2db55a0c70b1310e079849862889e58a4507bbe1..31c2fddbf19cdf8c328fd5dc3de0e7dd5779d34d 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1363,10 +1363,9 @@ class SsaBuilder extends ResolvedVisitor {
return reductiveHeuristic();
}
- if (cachedCanBeInlined == true) return cachedCanBeInlined;
-
- if (backend.functionsToAlwaysInline.contains(function)) {
- // Inline this function regardless of it's size.
+ if (cachedCanBeInlined == true) {
+ // We may have forced the inlining of some methods. Therefore check
+ // if we can inline this method regardless of size.
assert(InlineWeeder.canBeInlined(function, -1, false,
allowLoops: true));
return true;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/js_lib/annotations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698