Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: components/autofill/core/common/autofill_util.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments in autocomplete_history_manager.cc. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/autofill_util.h
diff --git a/components/autofill/core/common/autofill_util.h b/components/autofill/core/common/autofill_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..b07c48ec290104abca5f06c38c33117f0d492266
--- /dev/null
+++ b/components/autofill/core/common/autofill_util.h
@@ -0,0 +1,31 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_
+#define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_
+
+#include "base/strings/string16.h"
+
+namespace autofill {
+
+// Returns |true| when command line switch
+// |kEnableSuggestionsWithSubstringMatch| is on; otherwise |false|.
+bool IsFeatureSubstringMatchEnabled();
+
+// Splits field |suggestion| into tokens, separated by characters from " .,-_@".
+// Returns true if command line switch |kEnableSuggestionsWithSubstringMatch| is
+// on and |field_contents| is a prefix of some token.
please use gerrit instead 2015/06/29 22:06:29 "... of a token in |suggestion|."
Pritam Nikam 2015/06/30 15:05:51 Done.
+bool ContainsTokenThatStartsWith(const base::string16& suggestion,
+ const base::string16& field_contents,
+ bool case_sensitive);
+
+// Finds if the |field_contents| prefixes any of the |suggestion| token,
please use gerrit instead 2015/06/29 22:06:29 s/token/tokens
Pritam Nikam 2015/06/30 15:05:51 Done.
+// separated by characters from " .,-_@". Returns the start position of the text
please use gerrit instead 2015/06/29 22:06:29 Remove "from". It's a bit confusing IMHO.
Pritam Nikam 2015/06/30 15:05:51 Done.
+// selection in the field; base::string16::npos otherwise.
+size_t GetTextSelectionStart(const base::string16& suggestion,
+ const base::string16& field_contents);
+
+} // namespace autofill
+
+#endif // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698