components/autofill/core/browser/personal_data_manager.cc - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Evan's review comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/common/BUILD.gn » ('j') | components/autofill/core/common/autofill_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index 3de374087908278c47f8f293437efdba8b91dfa0..73dd72042162f9c38d641d798a1e0f9e141c5251 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -30,6 +30,7 @@

#include "components/autofill/core/browser/validation.h"

#include "components/autofill/core/common/autofill_pref_names.h"

#include "components/autofill/core/common/autofill_switches.h"

+#include "components/autofill/core/common/autofill_util.h"

#include "components/signin/core/common/signin_pref_names.h"

#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"

#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_formatter.h"

@@ -845,8 +846,8 @@ std::vector<Suggestion> PersonalDataManager::GetProfileSuggestions(

base::string16 value_canon =

AutofillProfile::CanonicalizeProfileString(values[i]);

- if (StartsWith(value_canon, field_contents_canon, true)) {

- // Prefix match, add suggestion.

+ if (IsContentsPrefixOfSuggestionToken(values[i], field_contents, true) ||

+ StartsWith(value_canon, field_contents_canon, true)) {

matched_profiles.push_back(profile);

suggestions.push_back(Suggestion(values[i]));

suggestions.back().backend_id.guid = profile->guid();