components/autofill/core/browser/suggestion.h - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/suggestion.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Vaclav's inputs. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/core/browser/personal_data_manager.cc ('k') | components/autofill/core/browser/suggestion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/suggestion.h

diff --git a/components/autofill/core/browser/suggestion.h b/components/autofill/core/browser/suggestion.h

index b9626449115e9fbf7dd2a2000c60b029ff2ae413..c9c43a24630494c6839fba5b05ed7496bb7e1741 100644

--- a/components/autofill/core/browser/suggestion.h

+++ b/components/autofill/core/browser/suggestion.h

@@ -31,6 +31,11 @@ struct SuggestionBackendID {

struct Suggestion {

public:

+ enum MatchMode {

+ PREFIX_MATCH, // for prefix matched suggestions;

+ SUBSTRING_MATCH // for substring matched suggestions;

+ };

Suggestion();

// Copy constructor for STL containers.

@@ -60,6 +65,7 @@ struct Suggestion {

base::string16 value;

base::string16 label;

base::string16 icon;

+ MatchMode match;

};

} // namespace autofill