[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/autofill/core/common/autofill_util_unittest.cc

Index: components/autofill/core/common/autofill_util_unittest.cc
diff --git a/components/autofill/core/common/autofill_util_unittest.cc b/components/autofill/core/common/autofill_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e2533a8a6f5dbaffaa6d3130eadbe1703b0e338e
--- /dev/null
+++ b/components/autofill/core/common/autofill_util_unittest.cc
@@ -0,0 +1,99 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/common/autofill_util.h"
+
+#include "base/command_line.h"
+#include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/common/autofill_switches.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace autofill {
+
+// Tests for FieldIsSuggestionSubstringStartingOnTokenBoundary().
+TEST(AutofillUtilTest, FieldIsSuggestionSubstringStartingOnTokenBoundary) {
+  // FieldIsSuggestionSubstringStartingOnTokenBoundary should not work yet
+  // without a flag.
+  EXPECT_FALSE(FieldIsSuggestionSubstringStartingOnTokenBoundary(
+      base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("a"), false));
+
+  // Token matching is currently behind a flag.
+  base::CommandLine::ForCurrentProcess()->AppendSwitch(
+      autofill::switches::kEnableSuggestionsWithSubstringMatch);
+
+  const struct {
+    const char* const field_suggestion;
+    const char* const field_contents;
+    bool case_sensitive;
+    bool expected_result;
+  } kTestCases[] = {
+      {"ab@cd.b", "a",    false, true},
+      {"ab@cd.b", "b",    false, true},
+      {"ab@cd.b", "Ab",   false, true},
+      {"ab@cd.b", "Ab",   true,  false},
+      {"ab@cd.b", "cd",   true,  true},
+      {"ab@cd.b", "d",    false, false},
+      {"ab@cd.b", "b@",   true,  false},
+      {"ab@cd.b", "ab",   false, true},
+      {"ab@cd.b", "cd.b", true,  true},
+      {"ab@cd.b", "b@cd", false, false},
+      {"ab@cd.b", "b",    false, true},

[vabr (Chromium), 2015/07/13 14:04:26]

You duplicated this line (see line 32), and there is still nothing testing a
prefix match with the field contents spanning multiple tokens. Please add
{"ab@cd.b", "ab@c", false, true}
as I asked you to do in my previous comment.

[Pritam Nikam, 2015/07/14 10:30:07]

Done.

I guess I've missed it out of excitement :)

+      {"ba.a.ab", "a.a",  false, true},
+      {"",        "ab",   false, false},
+      {"",        "ab",   true,  false},
+      {"ab",      "",     false, true},
+      {"ab",      "",     true,  true},
+  };
+
+  for (size_t i = 0; i < arraysize(kTestCases); ++i) {
+    SCOPED_TRACE(testing::Message()
+                 << "suggestion = " << kTestCases[i].field_suggestion
+                 << ", contents = " << kTestCases[i].field_contents
+                 << ", case_sensitive = " << kTestCases[i].case_sensitive);
+
+    EXPECT_EQ(kTestCases[i].expected_result,
+              FieldIsSuggestionSubstringStartingOnTokenBoundary(
+                  base::ASCIIToUTF16(kTestCases[i].field_suggestion),
+                  base::ASCIIToUTF16(kTestCases[i].field_contents),
+                  kTestCases[i].case_sensitive));
+  }
+}
+
+// Tests for GetTextSelectionStart().
+TEST(AutofillUtilTest, GetTextSelectionStart) {
+  const size_t kInvalid = base::string16::npos;
+  const struct {
+    const char* const field_suggestion;
+    const char* const field_contents;
+    bool case_sensitive;
+    size_t expected_start;
+  } kTestCases[] = {
+      {"ab@cd.b",              "a",       false, 1},
+      {"ab@cd.b",              "A",       true,  kInvalid},
+      {"ab@cd.b",              "Ab",      false, 2},
+      {"ab@cd.b",              "Ab",      true,  kInvalid},
+      {"ab@cd.b",              "cd",      false, 5},
+      {"ab@cd.b",              "ab@c",    false, 4},
+      {"ab@cd.b",              "cd.b",    false, 7},
+      {"ab@cd.b",              "b@cd",    false, kInvalid},
+      {"ab@cd.b",              "b",       false, 7},
+      {"ba.a.ab",              "a.a",     false, 6},
+      {"texample@example.com", "example", false, 16},
+  };
+
+  for (size_t i = 0; i < arraysize(kTestCases); ++i) {
+    SCOPED_TRACE(testing::Message()
+                 << "suggestion = " << kTestCases[i].field_suggestion
+                 << ", contents = " << kTestCases[i].field_contents
+                 << ", case_sensitive = " << kTestCases[i].case_sensitive);
+
+    EXPECT_EQ(kTestCases[i].expected_start,
+              GetTextSelectionStart(
+                  base::ASCIIToUTF16(kTestCases[i].field_suggestion),
+                  base::ASCIIToUTF16(kTestCases[i].field_contents),
+                  kTestCases[i].case_sensitive));
+  }
+}
+
+}  // autofill