[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 #include <set>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/autofill/core/common/autofill_regexes.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "components/autofill/core/common/autofill_util.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebElementCollection.h"
 #include "third_party/WebKit/public/web/WebFormControlElement.h"
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
@@ skipping 835 matching lines @@
       data.value.substr(0, input_element->maxLength()));
     input_element->setAutofilled(true);
   } else if (IsTextAreaElement(*field) || IsSelectElement(*field)) {
     field->setSuggestedValue(data.value);
     field->setAutofilled(true);
   }
 
   if (is_initiating_node &&
       (IsTextInput(input_element) || IsTextAreaElement(*field))) {
     // Select the part of the text that the user didn't type.
-    int start = field->value().length();
-    int end = field->suggestedValue().length();
-    field->setSelectionRange(start, end);
+    PreviewSuggestion(data.value, field);
   }
 }
 
 // Recursively checks whether |node| or any of its children have a non-empty
 // bounding box. The recursion depth is bounded by |depth|.
 bool IsWebNodeVisibleImpl(const blink::WebNode& node, const int depth) {
   if (depth < 0)
     return false;
   if (node.hasNonEmptyBoundingBox())
     return true;
@@ skipping 640 matching lines @@
 }
 
 gfx::RectF GetScaledBoundingBox(float scale, WebElement* element) {
   gfx::Rect bounding_box(element->boundsInViewportSpace());
   return gfx::RectF(bounding_box.x() * scale,
                     bounding_box.y() * scale,
                     bounding_box.width() * scale,
                     bounding_box.height() * scale);
 }
 
+void PreviewSuggestion(const base::string16& suggestion,
+                       WebFormControlElement* input_element) {
+  DCHECK(input_element);

[please use gerrit instead, 2015/06/29 22:06:28]

The rest of the code in this file does not DCHECK pointers before dereferencing
them. Let's be consistent and not DCHECK in your function either. No worries,
both DCHECK and dereference behave the same way (crash with a stack trace).

[Pritam Nikam, 2015/06/30 15:05:50]

Done.

+  input_element->setSelectionRange(
+      IsFeatureSubstringMatchEnabled()
+          ? autofill::GetTextSelectionStart(suggestion, input_element->value())

[please use gerrit instead, 2015/06/29 22:06:28]

Either use |suggestion| or input_element->suggestedValue() throughout the
function, but not both.

[Pritam Nikam, 2015/06/30 15:05:50]

Done.

+          : input_element->value().length(),
+      input_element->suggestedValue().length());
+}
+
 }  // namespace autofill