[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_tracker.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 #include "components/autofill/content/renderer/password_generation_agent.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "components/autofill/core/common/autofill_util.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/web_element_descriptor.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
@@ skipping 698 matching lines @@
                                        WebInputElement* node) {
   base::AutoReset<bool> auto_reset(&ignore_text_changes_, true);
   node->setEditingValue(value.substr(0, node->maxLength()));
 }
 
 void AutofillAgent::PreviewFieldWithValue(const base::string16& value,
                                           WebInputElement* node) {
   was_query_node_autofilled_ = element_.isAutofilled();
   node->setSuggestedValue(value.substr(0, node->maxLength()));
   node->setAutofilled(true);
-  node->setSelectionRange(node->value().length(),
-                          node->suggestedValue().length());
+
+  if (IsFeatureSubstringMatchEnabled()) {

[please use gerrit instead, 2015/06/28 00:43:03]

You can inline this:

node->setSelectionRange(
    IsFeatureSubstringMatchEnabled()
        ? autofill::GetTextSelectionStart(value, node->value())
        : node->value().length(),
    node->suggestedValue().length());

You use this code in at least two places. It's a good candidate to be placed
into autofill_util.h. Please do that. You can call it PreviewSuggestion() or
something better you can come up with.

[Pritam Nikam, 2015/06/29 15:38:21]

Sure, I'll move this code restructuring under |PreviewSuggestion()| API.
However, moving it to |autofill_util.h| will be a problem, as
|PreviewSuggestion()| will have blink dependency i.e. class WebInputElement, and
it'll not fly. Instead I've moved it to |form_autofill_util.h| i.e. under
content/renderer folder.

[please use gerrit instead, 2015/06/29 17:06:45]

Sounds good.

+    size_t start = autofill::GetTextSelectionStart(value, node->value());
+    node->setSelectionRange(start, node->suggestedValue().length());
+  } else {
+    node->setSelectionRange(node->value().length(),
+                            node->suggestedValue().length());
+  }
 }
 
 void AutofillAgent::ProcessForms() {
   // Record timestamp of when the forms are first seen. This is used to
   // measure the overhead of the Autofill feature.
   base::TimeTicks forms_seen_timestamp = base::TimeTicks::Now();
 
   WebLocalFrame* frame = render_frame()->GetWebFrame();
   std::vector<FormData> forms = form_cache_.ExtractNewForms();
 
@@ skipping 50 matching lines @@
 
 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
   // No-op. Don't delete |this|.
 }
 
 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() {
   agent_->FocusChangeComplete();
 }
 
 }  // namespace autofill