components/autofill/core/browser/autocomplete_history_manager.h - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/autocomplete_history_manager.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Evan's review inputs. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/content/renderer/form_autofill_util.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/browser/autocomplete_history_manager.cc » ('j') | components/autofill/core/common/autofill_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_

6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/gtest_prod_util.h"	10 #include "base/gtest_prod_util.h"

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 // Delegate to perform external processing (display, selection) on	76 // Delegate to perform external processing (display, selection) on

77 // our behalf. Weak.	77 // our behalf. Weak.

78 AutofillExternalDelegate* external_delegate_;	78 AutofillExternalDelegate* external_delegate_;

79	79

80 // Delegate to provide whether or not autocomplete functionality is enabled.	80 // Delegate to provide whether or not autocomplete functionality is enabled.

81 AutofillClient* const autofill_client_;	81 AutofillClient* const autofill_client_;

82	82

83 // Whether IPC is sent.	83 // Whether IPC is sent.

84 bool send_ipc_;	84 bool send_ipc_;

85	85

	86 // Field contents.

	87 base::string16 user_input_;
	Evan Stade 2015/04/27 19:25:21 this should be called pending_query_prefix_ and sh this should be called pending_query_prefix_ and should go near the other query vars Pritam Nikam 2015/04/28 14:45:55 Done. Show quoted text On 2015/04/27 19:25:21, Evan Stade wrote: > this should be called pending_query_prefix_ and should go near the other query > vars Done.
	88

86 DISALLOW_COPY_AND_ASSIGN(AutocompleteHistoryManager);	89 DISALLOW_COPY_AND_ASSIGN(AutocompleteHistoryManager);

87 };	90 };

88	91

89 } // namespace autofill	92 } // namespace autofill

90	93

91 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_	94 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_

OLD	NEW