Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: components/autofill/core/common/autofill_util_unittest.cc

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated Vaclav's review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/autofill/core/common/autofill_util.h"
6
7 #include "base/command_line.h"
8 #include "base/strings/utf_string_conversions.h"
9 #include "components/autofill/core/common/autofill_switches.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11
12 namespace autofill {
13
14 // Tests for IsContentsPrefixOfSuggestionToken().
15 TEST(AutofillUtilTest, IsContentsPrefixOfSuggestionToken) {
16 // IsContentsPrefixOfSuggestionToken should not work yet without a flag.
17 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
18 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("a"), false));
19
20 // Token matching is currently behind a flag.
21 base::CommandLine::ForCurrentProcess()->AppendSwitch(
22 autofill::switches::kEnableSuggestionsWithSubstringMatch);
23
24 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(
25 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("a"), false));
26 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(
27 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("b"), false));
28 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(
29 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("Ab"), false));
30 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
31 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("Ab"), true));
32 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(
33 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("cd"), true));
34 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
35 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("d"), false));
36 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
37 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("b@"), true));
38 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
39 base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("cd.b"), false));
40 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
41 base::string16(), base::ASCIIToUTF16("ab"), false));
42 EXPECT_FALSE(IsContentsPrefixOfSuggestionToken(
43 base::string16(), base::ASCIIToUTF16("ab"), true));
44 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(base::ASCIIToUTF16("ab"),
45 base::string16(), false));
46 EXPECT_TRUE(IsContentsPrefixOfSuggestionToken(base::ASCIIToUTF16("ab"),
47 base::string16(), true));
48 }
49
50 // Tests for ComputeRange().
51 TEST(AutofillUtilTest, ComputeRange) {
52 const struct {
53 base::string16 field_suggestion;
54 base::string16 field_contents;
55 size_t expected_offset;
56 size_t expected_start;
57 size_t expected_end;
58 } test_cases[] = {
59 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("a"), 0, 1, 7},
60 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("Ab"), 0, 2, 7},
61 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("cd"), 3, 5, 7},
62 {base::ASCIIToUTF16("ab@cd.b"),
63 base::ASCIIToUTF16("dc"),
64 base::string16::npos,
65 0,
66 0},
67 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("ab@c"), 0, 4, 7},
68 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("cd.b"), 3, 7, 7},
69 {base::ASCIIToUTF16("ab@cd.b"), base::ASCIIToUTF16("b"), 6, 7, 7},
70 {base::ASCIIToUTF16("ba.a.ab"), base::ASCIIToUTF16("a.a"), 3, 6, 7},
71 {base::ASCIIToUTF16("texample@example.com"),
72 base::ASCIIToUTF16("example"),
73 9,
74 16,
75 20},
76 {base::ASCIIToUTF16("texample@exam.com"),
77 base::ASCIIToUTF16("example"),
78 base::string16::npos,
79 0,
80 0}};
81
82 for (size_t i = 0; i < arraysize(test_cases); ++i) {
83 SCOPED_TRACE(testing::Message()
84 << "suggestion = " << test_cases[i].field_suggestion
85 << ", contents = " << test_cases[i].field_contents);
86
87 size_t start = 0;
88 size_t end = 0;
89 size_t offset = ComputeRange(test_cases[i].field_suggestion,
90 test_cases[i].field_contents, &start, &end);
91 EXPECT_EQ(test_cases[i].expected_offset, offset);
92 if (base::string16::npos != offset) {
93 EXPECT_EQ(test_cases[i].expected_start, start);
94 EXPECT_EQ(test_cases[i].expected_end, end);
95 }
96 }
97 }
98
99 } // autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698